Rollup of 6 pull requests #95558
Merged
Rollup of 6 pull requests #95558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are 0 by definition there.
…consts-from-trait-impls, r=jsha rustdoc: Only show associated consts from inherent impls in sidebar Resolves rust-lang#95459
ptr_metadata test: avoid ptr-to-int transmutes Pointers can have provenance, integers don't, so transmuting pointers to integers creates "non-standard" values and it is unclear how well those can be supported (rust-lang/unsafe-code-guidelines#286). So for this test let's take the safer option and use a pointer type instead. That also makes Miri happy. :)
skip slow int_log tests in Miri Iterating over i16::MAX many things takes a long time in Miri, let's not do that. I added rust-lang/miri#2044 on the Miri side to still give us some test coverage.
expand: Do not count metavar declarations on RHS of `macro_rules` They are 0 by definition there. Addresses rust-lang#95425 (comment) r? ```@nnethercote```
make utf8_char_counts test faster in Miri This currently takes >3min on GHA, so let's reduce the test size a bit more for Miri.
…n-docs, r=Amanieu add notes about alignment-altering reallocations to Allocator docs As I said in rust-lang/wg-allocators#97, the fact that calls to `grow`, `grow_zeroed`, and `shrink` may request altered alignments is surprising and may be a pitfall for implementors of `Allocator` if it's left implicit. This pull request adds a note to the "Safety" section of each function's docs making it explicit.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=6 |
|
📌 Commit a92286f has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (99da9ae): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
|
FYI for anyone falling along, the above performance improvements are not real. There was a change to one of the performance benchmarks that made all compilations of that benchmark take roughly half the time compared to the previous run. This rollup is performance neutral. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
macro_rules#95531 (expand: Do not count metavar declarations on RHS ofmacro_rules)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup