Skip to content

Rollup of 7 pull requests #92727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

seanchen1991 and others added 28 commits October 22, 2021 12:21

Verified

This commit was signed with the committer’s verified signature.
euclio Andy Russell

Verified

This commit was signed with the committer’s verified signature.
dtolnay David Tolnay

Verified

This commit was signed with the committer’s verified signature.
dtolnay David Tolnay

Verified

This commit was signed with the committer’s verified signature.
dtolnay David Tolnay
It's already a (fat) reference.
Double referencing it creates lifetime issues for its methods that want to return iterators.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The doc states that instants are not steady, but the word "not" wasn't highlighted in bold.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
… r=GuillaumeGomez

rustdoc: do not emit tuple variant fields if none are documented

Fixes rust-lang#90824.

Before:

![2021-12-15T22:26:41](https://user-images.githubusercontent.com/1372438/146302871-4d265433-b9aa-4e53-adfb-e7cb92107180.png)

After:

![2021-12-15T22:27:01](https://user-images.githubusercontent.com/1372438/146302872-e39eda3d-2fb2-4fb9-aae7-2008e4e1b4dd.png)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Add `std::error::Report` type

This is a continuation of rust-lang#90174, split into a separate PR since I cannot push to ```@seanchen1991``` 's fork

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
rustc_metadata: Stop passing `CrateMetadataRef` by reference (step 1)

It's already a (fat) reference.
Double referencing it creates lifetime issues for its methods that want to return iterators.

---
Extracted from rust-lang#92245 for a perf run.
The PR changes a lot of symbol names due to function signature changes, so it's hard to do differential profiling, let's spend some machine time instead.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…uillaumeGomez

rustdoc: Preserve rendering of macro_rules matchers when possible

Fixes rust-lang#92331. This approach restores the behavior prior to rust-lang#86282 **if** the matcher token held by the compiler **and** the matcher token found in the source code are identical TokenTrees. Thus rust-lang#86208 remains fixed, but without regressing formatting for the vast majority of macros which are not macro-generated.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
… r=pietroalbini

RELEASES.md: Add 1.58 release note for `File::options` stabilization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Extended the note on the use of `no_run` attribute

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix doc formatting for time.rs

The doc states that instants are not steady, but the word "not" wasn't highlighted in bold.
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 10, 2022
@rustbot rustbot added the rollup A PR which is a rollup label Jan 10, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Collaborator

bors commented Jan 10, 2022

📌 Commit e898494 has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2022
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Checking tracing-tree v0.2.0
    Checking rustdoc-json-types v0.1.0 (/checkout/src/rustdoc-json-types)
    Checking tera v1.10.0
    Checking rustdoc v0.0.0 (/checkout/src/librustdoc)
error[E0599]: no method named `maybe_collapsed_doc_value` found for struct `Rc<SharedContext<'_>>` in the current scope
    --> src/librustdoc/html/render/print_item.rs:1142:56
     |
1142 |                     if fields.iter().any(|f| cx.shared.maybe_collapsed_doc_value(f).is_some()) =>
     |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `Rc<SharedContext<'_>>`
For more information about this error, try `rustc --explain E0599`.
error: could not compile `rustdoc` due to previous error
Build completed unsuccessfully in 0:02:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet