Skip to content

Update miri #90390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2021
Merged

Update miri #90390

merged 1 commit into from
Oct 29, 2021

Conversation

umanwizard
Copy link
Contributor

@umanwizard umanwizard commented Oct 29, 2021 •
edited by RalfJung
Loading

Fixes #90298

@rust-highfive
Copy link
Contributor

Some changes occured to the Miri submodule

cc @rust-lang/miri

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2021
@RalfJung
Copy link
Member

Thanks!
@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Oct 29, 2021

📌 Commit 2b66af1 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2021
@bors
Copy link
Collaborator

bors commented Oct 29, 2021

⌛ Testing commit 2b66af1 with merge e99963c...

@bors
Copy link
Collaborator

bors commented Oct 29, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing e99963c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 29, 2021
@bors bors merged commit e99963c into rust-lang:master Oct 29, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 29, 2021
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #90390!

Tested on commit e99963c.
Direct link to PR: #90390

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 29, 2021
@rust-highfive
📣 Toolstate changed by rust-lang/rust#90390!
1478d8f 
Tested on commit rust-lang/rust@e99963c.
Direct link to PR: <rust-lang/rust#90390>

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e99963c): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#85830
7 participants
@umanwizard @rust-highfive @RalfJung @bors @rust-timer @Mark-Simulacrum @rustbot