-
Notifications
You must be signed in to change notification settings - Fork 13.3k
#[inline]
non-generic pub fn
s in rustc_target::abi
and ty::layout
.
#88326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 94b11f66fa9b994d0f3be4b7807f1bc6e364edde with merge 54d4ab1b221a642ac4dd0be99a815d0061126a41... |
☀️ Try build successful - checks-actions |
Queued 54d4ab1b221a642ac4dd0be99a815d0061126a41 with parent 9863bf5, future comparison URL. |
Finished benchmarking try commit (54d4ab1b221a642ac4dd0be99a815d0061126a41): comparison url. Summary: This change led to moderate relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
@bors r+ |
📌 Commit 94b11f66fa9b994d0f3be4b7807f1bc6e364edde has been approved by |
☔ The latest upstream changes (presumably #88308) made this pull request unmergeable. Please resolve the merge conflicts. |
94b11f6
to
efb4148
Compare
@bors r=oli-obk |
📌 Commit efb4148 has been approved by |
☀️ Test successful - checks-actions |
Looks like the perf run after landing was a bit of a wash, I wonder if #88308 made it harder to have improvements in layout-adjacent code. |
Mostly doing this as a perf curiosity, having spotted that
#[inline]
usage is a bit spotty.