-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Only include lint in future_incompatible lint group if not an edition lint #86689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,18 @@ | ||
// Ensure that the future_incompatible lint group only includes | ||
// lints for changes that are not tied to an edition | ||
#![deny(future_incompatible)] | ||
|
||
trait Tr { | ||
fn f(u8) {} //~ ERROR anonymous parameters are deprecated | ||
//~^ WARN this is accepted in the current edition | ||
// Warn only since this is not a `future_incompatible` lint | ||
fn f(u8) {} //~ WARN anonymous parameters are deprecated | ||
//~| WARN this is accepted in the current edition | ||
} | ||
|
||
pub mod submodule { | ||
// Error since this is a `future_incompatible` lint | ||
#![doc(test(some_test))] | ||
//~^ ERROR this attribute can only be applied at the crate level | ||
//~| WARN this was previously accepted by the compiler | ||
} | ||
|
||
fn main() {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,28 @@ | ||
error: anonymous parameters are deprecated and will be removed in the next edition. | ||
--> $DIR/future-incompatible-lint-group.rs:4:10 | ||
warning: anonymous parameters are deprecated and will be removed in the next edition. | ||
--> $DIR/future-incompatible-lint-group.rs:7:10 | ||
| | ||
LL | fn f(u8) {} | ||
| ^^ help: try naming the parameter or explicitly ignoring it: `_: u8` | ||
| | ||
= note: `#[warn(anonymous_parameters)]` on by default | ||
= warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! | ||
= note: for more information, see issue #41686 <https://github.com/rust-lang/rust/issues/41686> | ||
|
||
error: this attribute can only be applied at the crate level | ||
--> $DIR/future-incompatible-lint-group.rs:13:12 | ||
| | ||
LL | #![doc(test(some_test))] | ||
| ^^^^^^^^^^^^^^^ | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/future-incompatible-lint-group.rs:1:9 | ||
--> $DIR/future-incompatible-lint-group.rs:3:9 | ||
| | ||
LL | #![deny(future_incompatible)] | ||
| ^^^^^^^^^^^^^^^^^^^ | ||
= note: `#[deny(anonymous_parameters)]` implied by `#[deny(future_incompatible)]` | ||
= warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! | ||
= note: for more information, see issue #41686 <https://github.com/rust-lang/rust/issues/41686> | ||
= note: `#[deny(invalid_doc_attributes)]` implied by `#[deny(future_incompatible)]` | ||
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
= note: for more information, see issue #82730 <https://github.com/rust-lang/rust/issues/82730> | ||
= note: read https://doc.rust-lang.org/nightly/rustdoc/the-doc-attribute.html#at-the-crate-level for more information | ||
|
||
error: aborting due to previous error | ||
error: aborting due to previous error; 1 warning emitted | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.