-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[Do not merge] Learn the performance impact of running lints, take 2 #86543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The job Click to see the possible cause of the failure (guessed by this bot)
|
I would be surprised if it's changed a lot, but it doesn't hurt anything to check. @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 66b7e96 with merge 5e342426fd7d19b970dc77f2d1f2f1d45aee606a... |
☀️ Try build successful - checks-actions |
Queued 5e342426fd7d19b970dc77f2d1f2f1d45aee606a with parent 44f4a87, future comparison URL. |
Finished benchmarking try commit (5e342426fd7d19b970dc77f2d1f2f1d45aee606a): comparison url. Summary: This change led to significant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Looks like lints have a larger impact now. |
It has been almost a year since #74718, so I am requesting a perf run to reassess how running lints affect performance.
r? @ghost
cc @jyn514