Skip to content

Conversation

davidhewitt
Copy link
Contributor

See discussion in #84502 - I'm worried that #84445 may cause a lot of breakages if this were to hit stable, so I think it's safer to revert and work on the known correct fix #84478.

@rust-highfive
Copy link
Contributor

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2021
@GuillaumeGomez
Copy link
Member

I'll go forward with this revert until we can find a better improvement overall.

@bors: r+ p=1

@bors
Copy link
Collaborator

bors commented Apr 24, 2021

📌 Commit 5b05f68 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2021
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 24, 2021
@bors
Copy link
Collaborator

bors commented Apr 24, 2021

⌛ Testing commit 5b05f68 with merge fb1917fb2ef7fd51a783317f1c9421951ae8d0f7...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@GuillaumeGomez
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Apr 24, 2021

⌛ Testing commit 5b05f68 with merge 42816d6...

@bors
Copy link
Collaborator

bors commented Apr 24, 2021

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 42816d6 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a proper lexer for hiding code in doctests
7 participants