Skip to content

Try MIR inlining leaf functions by default #81079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Try MIR inlining leaf functions by default #81079

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7f55f07
Inline trivial implementation of std::iter::Empty
tmiasko Jan 15, 2021
b7e28e3
Make arithmetic overflow in step implementations conditional
tmiasko Jan 16, 2021
cf78d93
Disable inlining without a warining when coverage is enabled
tmiasko Jan 15, 2021
f0f5e19
Inline trivial leaf functions
lcnr Jan 15, 2021
27f7c24
Disable MIR optimizations in inline-hint test
tmiasko Jan 16, 2021
2278495
Use nearest non-inlined scope for as lint root in const prop
tmiasko Jan 16, 2021
639c1ff
Remove locals used only by debuginfo at opt-level=3
tmiasko Jan 16, 2021
c30cffd
Disable call terminator validation
tmiasko Jan 16, 2021
aefc721
Make polymorphization tests independent of MIR inlining
tmiasko Jan 16, 2021
3d43b90
Make instantiation limit test independent of MIR inlining
tmiasko Jan 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/core/src/iter/range.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ macro_rules! step_identical_methods {
// In debug builds, trigger a panic on overflow.
// This should optimize completely out in release builds.
if Self::forward_checked(start, n).is_none() {
let _ = Add::add(Self::MAX, 1);
let _ = Add::add(usize::MAX, n);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 nice trick

}
// Do wrapping math to allow e.g. `Step::forward(-128i8, 255)`.
start.wrapping_add(n as Self)
Expand All @@ -215,7 +215,7 @@ macro_rules! step_identical_methods {
// In debug builds, trigger a panic on overflow.
// This should optimize completely out in release builds.
if Self::backward_checked(start, n).is_none() {
let _ = Sub::sub(Self::MIN, 1);
let _ = Sub::sub(usize::MIN, n);
}
// Do wrapping math to allow e.g. `Step::backward(127i8, 255)`.
start.wrapping_sub(n as Self)
Expand Down
6 changes: 6 additions & 0 deletions library/core/src/iter/sources/empty.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,24 +44,28 @@ impl<T> fmt::Debug for Empty<T> {
impl<T> Iterator for Empty<T> {
type Item = T;

#[inline]
fn next(&mut self) -> Option<T> {
None
}

#[inline]
fn size_hint(&self) -> (usize, Option<usize>) {
(0, Some(0))
}
}

#[stable(feature = "iter_empty", since = "1.2.0")]
impl<T> DoubleEndedIterator for Empty<T> {
#[inline]
fn next_back(&mut self) -> Option<T> {
None
}
}

#[stable(feature = "iter_empty", since = "1.2.0")]
impl<T> ExactSizeIterator for Empty<T> {
#[inline]
fn len(&self) -> usize {
0
}
Expand All @@ -77,6 +81,7 @@ impl<T> FusedIterator for Empty<T> {}
// which isn't necessary.
#[stable(feature = "iter_empty", since = "1.2.0")]
impl<T> Clone for Empty<T> {
#[inline]
fn clone(&self) -> Empty<T> {
Empty(marker::PhantomData)
}
Expand All @@ -86,6 +91,7 @@ impl<T> Clone for Empty<T> {
// which isn't necessary.
#[stable(feature = "iter_empty", since = "1.2.0")]
impl<T> Default for Empty<T> {
#[inline]
fn default() -> Empty<T> {
Empty(marker::PhantomData)
}
Expand Down