Skip to content

Conversation

@pnadon
Copy link
Contributor

@pnadon pnadon commented Jul 21, 2020

Renamed the function ScalarMaybeUninit::not_undef
to
ScalarMaybeUninit::check_init
in the file src/librustc_middle/mir/interpret/value.rs, to reflect changes in terminology used.

Related issue rust-lang#71193

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2020
@pnadon pnadon marked this pull request as ready for review July 21, 2020 23:59
@pnadon pnadon changed the title Miri: Renamed ScalarMaybeUninit::not_undef to check_init Miri: Rename undef to uninit Jul 22, 2020
@petrochenkov
Copy link
Contributor

r? @RalfJung

@pnadon pnadon closed this Jul 23, 2020
@RalfJung
Copy link
Member

(I assume I can ignore this PR.)

@pnadon
Copy link
Contributor Author

pnadon commented Jul 23, 2020

Yes that's correct, I have opened another one here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants