Nix rustc_hir reexports in rustc::hir
#67886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
rustc_hir_canon_imports
branch
from
25c0999 to
91fa014
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JohnTitor
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
rustc_hir_canon_imports
branch
from
bf953f3 to
0156368
Compare
|
Seems to be passing now..., finally :) |
nagisa
reviewed
Jan 6, 2020
|
@bors r+ |
|
📌 Commit 0156368 has been approved by |
bors
added
S-waiting-on-bors
|
r? @nagisa |
|
Raising the prio of this a bit because it's blocking other work and because it's bit-rotty. @bors p=1 |
|
⌛ Testing commit 0156368 with merge d6e24cb7218cfdc7f8e1563df7f34b128be14049... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors retry seems spurious. |
bors
added
S-waiting-on-bors
Merged
|
☀️ Test successful - checks-azure |
This was referenced Jan 6, 2020
|
📣 Toolstate changed by #67886! Tested on commit ebbb2bf. 💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jan 6, 2020
Tested on commit rust-lang/rust@ebbb2bf. Direct link to PR: <rust-lang/rust#67886> 💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
This was referenced Jan 6, 2020
Closed
JohnTitor
added a commit
to JohnTitor/rust-clippy
that referenced
this pull request
Jan 6, 2020
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jan 6, 2020
Rustup to rust-lang/rust#67886 changelog: none
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jan 6, 2020
Rustup to rust-lang/rust#67886 changelog: none
defunctio
pushed a commit
to defunctio/rust-clippy
that referenced
this pull request
Jan 7, 2020
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Apr 16, 2023
It makes for confusing code. This was introduced in a large commit in rust-lang#67886 that rearranged a lot of `use` statements. I suspect it was an accident.
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Apr 16, 2023
…t, r=fee1-dead Don't `use rustc_hir as ast`(!) It makes for confusing code. This was introduced in a large commit in rust-lang#67886 that rearranged a lot of `use` statements. I suspect it was an accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Zoxc cc @Mark-Simulacrum