-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Initial implementation of or-pattern usefulness checking #66612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6e85f46
Initial implementation of or-pattern usefulness checking
Nadrieril 0030a77
Add some more tests
Nadrieril b5ec4d1
Address reviews
Nadrieril cdc844e
Make the ice a fatal error
Nadrieril 0881750
Move tests to ui, split them and add some
Nadrieril 0f4c5fb
Apply suggestions from code review
Nadrieril File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// should-ice | ||
Nadrieril marked this conversation as resolved.
Show resolved
Hide resolved
|
||
#![allow(incomplete_features)] | ||
#![feature(or_patterns)] | ||
#![deny(unreachable_patterns)] | ||
|
||
// The ice will get removed once or-patterns are correctly implemented | ||
fn main() { | ||
// We wrap patterns in a tuple because top-level or-patterns are special-cased for now. | ||
match (0u8,) { | ||
Nadrieril marked this conversation as resolved.
Show resolved
Hide resolved
|
||
(1 | 2,) => {} | ||
//~^ ERROR simplifyable pattern found | ||
// This above is the ICE error message | ||
_ => {} | ||
} | ||
|
||
match (0u8,) { | ||
(1 | 2,) => {} | ||
(1,) => {} //~ ERROR unreachable pattern | ||
_ => {} | ||
} | ||
match (0u8,) { | ||
(1 | 2,) => {} | ||
(2,) => {} //~ ERROR unreachable pattern | ||
_ => {} | ||
} | ||
match (0u8,) { | ||
(1,) => {} | ||
(2,) => {} | ||
(1 | 2,) => {} //~ ERROR unreachable pattern | ||
_ => {} | ||
} | ||
match (0u8,) { | ||
(1 | 1,) => {} // redundancy not detected for now | ||
_ => {} | ||
} | ||
match (0u8, 0u8) { | ||
(1 | 2, 3 | 4) => {} | ||
(1, 2) => {} | ||
(1, 3) => {} //~ ERROR unreachable pattern | ||
(1, 4) => {} //~ ERROR unreachable pattern | ||
(2, 4) => {} //~ ERROR unreachable pattern | ||
(2 | 1, 4) => {} //~ ERROR unreachable pattern | ||
_ => {} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.