Skip to content

Be accurate on format! parse error expectations #64080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Sep 1, 2019

Fix #57277.

@rust-highfive
Copy link
Contributor

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2019
@estebank estebank changed the title Parse format comma @estebank Be accurate on format! parse error expectations Sep 2, 2019
@estebank estebank changed the title @estebank Be accurate on format! parse error expectations Be accurate on format! parse error expectations Sep 2, 2019
@JohnCSimon
Copy link
Member

ping from triage

@zackmdavis Can you please review this?
CC @estebank
Thank you.

@zackmdavis
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 14, 2019

📌 Commit 4dec571 has been approved by zackmdavis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2019
@bors
Copy link
Collaborator

bors commented Sep 14, 2019

⌛ Testing commit 4dec571 with merge 4576668...

bors added a commit that referenced this pull request Sep 14, 2019
Be accurate on `format!` parse error expectations

Fix #57277.
@bors
Copy link
Collaborator

bors commented Sep 14, 2019

☀️ Test successful - checks-azure
Approved by: zackmdavis
Pushing 4576668 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 14, 2019
@bors bors merged commit 4dec571 into rust-lang:master Sep 14, 2019
@estebank estebank deleted the parse-format-comma branch November 9, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

format! parse error expectations are sometimes inaccurate
5 participants