Correctly use #[cfg()] on Redox #63714
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redox does not implement `setgroups`. The current implementation tries to work around this, but will still fail to build if libc::setgroups is not defined. This means libstd cannot compile for Redox. This change fixes this by using `#[cfg(...)]` instead of `if cfg!(...)`.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Just noticed that this is getting fixed in #63521, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redox does not implement
setgroups. The current implementation triesto work around this, but will still fail to build if libc::setgroups is
not defined.
This means libstd cannot compile for Redox. This change fixes this
by using
#[cfg(...)]instead ofif cfg!(...).Unblocks #63521