Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Aug 8, 2019

Successful merges:

Failed merges:

r? @ghost

RalfJung and others added 14 commits August 4, 2019 14:50
bump rand in libcore/liballoc test suites

This pulls in the fix for rust-random/rand#779, which trips Miri when running these test suites.

`SmallRng` (formerly used by libcore) is no longer built by default, it needs a feature gate. I opted to switch to `StdRng` instead. Or should I enable the feature gate?
…imulacrum

Update rustfmt to 1.4.4

The update includes bug fixes.
…ichton

Don't use remap-path-prefix in dep-info files.

This changes it so that dep-info files do not use remapped paths.

Having remapped paths causes problems with Cargo because if you remap to a nonexistent path (like `/rustc/$HASH` which rustc distributions do), then Cargo's change tracking thinks the files don't exist and will always rebuild.

I don't actually know if this is a good idea. I think it makes sense, but I do not know what the exact requirements are for reproducible builds. I consider these files separate from the binary artifacts generated, and as a build-system helper, so it seems reasonable to me.

I'm also not sure if this needs a test. I'll definitely add one on the cargo side if this is merged.

Closes rust-lang#63329
…r=Centril

doc: Fix typo in float from bytes methods

Thanks @That3Percent for pointing it out.
r? @Centril
Improved documentation for compile_error!()

Fixes rust-lang#63375
@Centril
Copy link
Contributor Author

Centril commented Aug 8, 2019

@bors r+ p=6 rollup=never

@bors
Copy link
Collaborator

bors commented Aug 8, 2019

📌 Commit ece44d9 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 8, 2019
@Centril Centril closed this Aug 8, 2019
@Centril Centril deleted the rollup-65n7a39 branch August 8, 2019 14:41
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants