Skip to content

wfcheck: no need for ICE on unresolved type expression #62212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/librustc_typeck/check/wfcheck.rs
Original file line number Diff line number Diff line change
Expand Up @@ -270,12 +270,7 @@ fn check_type_defn<'tcx, F>(
let ty = variant.fields.last().unwrap().ty;
fcx.tcx.erase_regions(&ty).lift_to_tcx(fcx_tcx)
.map(|ty| ty.needs_drop(fcx_tcx, fcx_tcx.param_env(def_id)))
.unwrap_or_else(|| {
fcx_tcx.sess.delay_span_bug(
item.span, &format!("inference variables in {:?}", ty));
// Just treat unresolved type expression as if it needs drop.
true
})
.unwrap_or(true) // #61402 treat unresolved type expression as needs-drop
}
};
let all_sized =
Expand Down
22 changes: 22 additions & 0 deletions src/test/run-pass/packed-with-inference-vars-issue-61402.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// rust-lang/rust#61402: if a struct is packed and the last
// field of the struct needs drop glue, then the compiler's well-formedness check
// will put a Sized bound on that last field.
//
// However, we do not want to ICE the compiler in our attempt to
// avoid adding that Sized bound; it is better to just let a
// potentially unneeded constraint through.

#![allow(unused_imports, dead_code)]

pub struct S;

pub trait Trait<R> { type Assoc; }

impl<X> Trait<X> for S { type Assoc = X; }

#[repr(C, packed)]
struct PackedAssocSized {
pos: Box<<S as Trait<usize>>::Assoc>,
}

fn main() { println!("Hello, world!"); }