Repository navigation
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| if let Mode::CodegenUnits = config.mode { | ||
| // codegen-units tests use wrong directory, for more info see | ||
| // https://github.com/rust-lang/rust/issues/34586#issuecomment-501681886 | ||
| if let Ok(build_dir) = env::var("BUILD_DIR") { |
There was a problem hiding this comment.
Hmm, if the problem is that we are passing -Zincremental=tmp/foo, maybe it would be better to have some way to alter the command-line flags to include the correct directory?
I'm imagining:
// compile-flags:-Zincremental=$BUILD_DIR/tmp/...
for example? (We'd have to replace that $BUILD_DIR of course.)
There was a problem hiding this comment.
I'm a bit worried about side-effects from changing the current directory in a narrow range of cases.
There was a problem hiding this comment.
Environment variables doesn't seem to be expanded in compile-flags and that results in $VARIABLE/tmp/... directory.
I'm a bit worried about side-effects from changing the current directory in a narrow range of cases.
When I enabled it for everything only 3 rustdoc tests broke(I was building with --no-fail-fast), I haven't investigated further but they should be fixable.
|
ping from triage @nikomatsakis @mati865 any updates? |
Dylan-DPC-zz
added
S-inactive
4 participants
Fixes #34586