-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[beta] rustdoc: disable blanket impl collection #54102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
QuietMisdreavus
wants to merge
58
commits into
rust-lang:master
from
QuietMisdreavus:beta-disable-blankets
Closed
[beta] rustdoc: disable blanket impl collection #54102
QuietMisdreavus
wants to merge
58
commits into
rust-lang:master
from
QuietMisdreavus:beta-disable-blankets
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulacrum Beta for 1.29.0
…imulacrum [beta] Rollup backports & switch bootstrap compiler This PR switches the bootstrap compiler from dev-static to static, and rollups some backports. Merged and approved: * rust-lang#52929: Update compatibility note for 1.28.0 to be correct * rust-lang#52918: Backport 1.27.2 release notes * rust-lang#52867: releases.md: fix 2 typos * rust-lang#52996: RELEASES.md: fix the `hash_map::Entry::or_default` link r? @Mark-Simulacrum
Includes backporting the rustc workspace hack
Update RLS, Rustfmt, Clippy Includes backporting the rustc workspace hack. Clippy is only updated to be compatible with the other tools. RLS and Rustfmt are 1.0 RCs. r? @alexcrichton
[beta] Update the clippy submodule Clippy didn't build on the beta branch because of a rustc version sanity check r? @kennytm
…en necessary. Namely, the code here was trying to be clever, and say "lets not report diagnostics when we 'know' NLL will report an error about them in the future." The problem is that in migration mode, when no error was reported here, the NLL error that we "knew" was coming was downgraded to a warning (!). This fixes that by only doing the "clever" skipping of region error reporting when we are not in migration mode. Rather than make a separate test for issue 53026, I just took the test that uncovered this in a first place, and extended it (via our revisions system) to explicitly show all three modes in action: ACT-borrowck, NLL, and NLL migration mode. (Tto be honest I hope not to have to add such revisions to many tests. Instead I hope to adopt some sort of new `compare-mode` for either borrowck=migrate or for the 2018 edition as a whole.)
…albini [beta] Rollup backports Merged and approved: * rust-lang#53030: Updated RELEASES.md for 1.29.0 * rust-lang#53594: Update RELEASES.md to include clippy-preview * rust-lang#53045: Fix NLL migration mode so that reports region errors when necessary. * rust-lang#53163: Remove an overly pedantic and wrong assertion r? @ghost
…olution This allows import resolution to progress in cases like rust-lang#53140
This hack was removed in rust-lang#50949, but without it I found that building `std` with full debuginfo would print many LLVM `DW_OP_LLVM_fragment` errors, then die `LLVM ERROR: Failed to strip malformed debug info`. It doesn't seem to be a problem for LLVM 6, so we can re-enable the hack just for older LLVM. This reverts commit da579ef. Fixes rust-lang#53204. r? @eddyb
…albini [beta] Rollup backports Merged and approved: * rust-lang#53559: add macro check for lint * rust-lang#53509: resolve: Reject some inaccessible candidates sooner during import resolution * rust-lang#53239: rustc_codegen_llvm: Restore the closure env alloca hack for LLVM 5. * rust-lang#53235: Feature gate where clauses on associated type impls * rust-lang#53516: resolve: Continue search in outer scopes after applying derive resolution fallback r? @ghost
[beta] Don't sanity check function pointers in vtables cc rust-lang#53401 There's no beta nomination because the full fix (rust-lang#53424) is not backportable
[beta] const eval perf regression fix backports rust-lang#52925 (for rust-lang#52849) and additionally skips hashing on every evaluation step
…iven `Mark`" This reverts commit b15785b.
The former code used `target.contains("64")` to detect Elf64 targets, but this is inaccurate in a few cases: - `s390x-unknown-linux-gnu` is 64-bit - `sparcv9-sun-solaris` is 64-bit - `x86_64-unknown-linux-gnux32` is 32-bit Instead the `std` build script can use `CARGO_CFG_TARGET_POINTER_WIDTH` to reliably detect 64-bit targets for libbacktrace. Also update to backtrace-sys 0.1.24 for rust-lang/backtrace-rs#122.
If we detect a local rebuild (e.g. bootstrap compiler is the same version as target compiler), we set stage to 1. When trying to build e.g. UnstableBook, we use Mode::ToolBootstrap and stage is 1. Just allow Mode::ToolBootstrap and stagge != 0 if we are in a local_rebuild Signed-off-by: Marc-Antoine Perennou <[email protected]>
…albini [beta] Rollup backports Merged and approved: * rust-lang#53653: Address two regressions * rust-lang#53377: std: Use target_pointer_width for BACKTRACE_ELF_SIZE * rust-lang#52969: rustbuild: fix local_rebuild r? @ghost
Update LLVM to fix segfault on AArch64 Fixes rust-lang#53742 This is a backport of rust-lang#52952 to beta cc @alexcrichton
The former code used `target.contains("64")` to detect Elf64 targets, but this is inaccurate in a few cases: - `s390x-unknown-linux-gnu` is 64-bit - `sparcv9-sun-solaris` is 64-bit - `x86_64-unknown-linux-gnux32` is 32-bit Instead the `std` build script can use `CARGO_CFG_TARGET_POINTER_WIDTH` to reliably detect 64-bit targets for libbacktrace. Also update to backtrace-sys 0.1.24 for rust-lang/backtrace-rs#122.
…lbini [beta] update backtrace-sys to 0.1.24 This is the other part of rust-lang#53377 that was missed in the rust-lang#53880 backport. r? @pietroalbini
[beta] Properly prevent the promotion of unstable const fns backport of rust-lang#53699 r? @nikomatsakis (the other PR was merged and beta nominated but not beta approved)
Added in rust-lang#52149 the discussion in rust-lang#53514 is showing how we may not want to actually add this attribute to the atomic types. While we continue to debate rust-lang#53514 this commit reverts the addition of the `transparent` attribute before it hits stable.
…atomics, r=nikomatsakis [beta]: Remove `#[repr(transparent)]` from atomics Added in rust-lang#52149 the discussion in rust-lang#53514 is showing how we may not want to actually add this attribute to the atomic types. While we continue to debate rust-lang#53514 this commit reverts the addition of the `transparent` attribute before it hits stable.
Beta still requires them.
…albini [beta] Rollup backports Merged and approved: * rust-lang#53893: Validate syntax of `cfg` attributes r? @ghost
Ack, looks like i got the base branch wrong. I'm going to try to reopen this on the right branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta patch for #52873 so we don't propagate the ICE into stable.
r? @rust-lang/rustdoc @Mark-Simulacrum