Code

Misc lowering cleanups#51654

Code

Closed

oli-obk wants to merge 20 commits intorust-lang:masterrust-lang/rust:masterfrom

oli-obk:cleanupsoli-obk/rust:cleanupsCopy head branch name to clipboard

Commits

Commits on Jun 22, 2018

• Use `PathParameters` even if just the `lifetimes` field is used

  oli-obk

  committed
  4093d37

  Copy full SHA for 4093d37

• Cleanup in preparation of generic extraction

  oli-obk

  committed
  5181218

  Copy full SHA for 5181218

• Generate the `NodeId` for `existential type` in the AST

  oli-obk

  committed
  dea4d5b

  Copy full SHA for dea4d5b

• Reduce repetition around `lower_method_sig`

  oli-obk

  committed
  2b7f86a

  Copy full SHA for 2b7f86a

• Deduplicate code in `lower_lifetime`

  oli-obk

  committed
  0dcb45e

  Copy full SHA for 0dcb45e

• Remove some global state from the lowering pass

  oli-obk

  committed
  98d4500

  Copy full SHA for 98d4500

• Pass generics through to existential impl Trait lowering

  oli-obk

  committed
  3ae2e31

  Copy full SHA for 3ae2e31

• Don't generate a new NodeId for universal impl Trait

  oli-obk

  committed
  3dbe348

  Copy full SHA for 3dbe348

• Generate `DefId`s for impl Trait in the def_collector

  oli-obk

  committed
  90a54c1

  Copy full SHA for 90a54c1

• Update ui tests

  oli-obk

  committed
  2fdb64c

  Copy full SHA for 2fdb64c

• While we don't have full existential types yet, there is some duplication in privacy related errors for impl Trait

  oli-obk

  committed
  19f5e5e

  Copy full SHA for 19f5e5e

• Flatten some occurrences of `[P<T>]` to `[T]`

  oli-obk

  committed
  a83733f

  Copy full SHA for a83733f

• Prevent lowering item ids from behaving differently than lowering items

  oli-obk

  committed
  47732a4

  Copy full SHA for 47732a4

• Update rustdoc

  oli-obk

  committed
  057cf0f

  Copy full SHA for 057cf0f

• We now have proper locations for the `existential type` items.

  oli-obk

  committed
  1bf351d

  Copy full SHA for 1bf351d

• Also place method impl trait into the surrounding module

  oli-obk

  committed
  356d683

  Copy full SHA for 356d683

• Ignore existential type items during collection for now

  oli-obk

  committed
  398a5f8

  Copy full SHA for 398a5f8

• Don't try to do impl Trait lowering for `impl Trait for Type` items

  oli-obk

  committed
  9859a52

  Copy full SHA for 9859a52

Commits on Jun 25, 2018

• Generics Unification rebase fallout

  oli-obk

  committed
  a152770

  Copy full SHA for a152770

• Update tests

  oli-obk

  committed
  922249c

  Copy full SHA for 922249c