-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Command: Support posix_spawn() on FreeBSD/OSX/GNU Linux #48624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
518b3f7
Update libc to bring in posix_spawn bindings for FreeBSD.
bdrewery 11696ac
Support posix_spawn() when possible.
alexcrichton f463386
Avoid error for unused variables
bdrewery 94630e4
No need to zero when an initializer for the object is already used.
bdrewery 8e3fa0d
Pass proper pointer for envp.
bdrewery b3ecf5f
Remove excess newline
bdrewery 85b82f2
Support posix_spawn() for FreeBSD.
bdrewery e6efd0d
Add a specific test for spawn() returning ENOENT
bdrewery a9ea876
posix_spawn() always returns its error rather than setting errno.
bdrewery 2e2d926
posix_spawn() on OSX supports returning ENOENT.
bdrewery ef73b3a
Add comment explaining when posix_spawn() can be supported.
bdrewery 99b50ef
Use _
bdrewery 5ba6b3a
Move glibc version lookup handling to sys::os and add a simpler glibc…
bdrewery d740083
Support posix_spawn() for Linux glibc 2.24+.
bdrewery 57c74c3
Update beta to version with fixed FreeBSD support from #49023.
bdrewery 00dac20
Merge branch 'update-beta-freebsd' into freebsd-posix-spawn
bdrewery 6212904
Don't use posix_spawn() if PATH was modified in the environment.
bdrewery 8e0faf7
Simplify PATH key comparison
bdrewery 70559c5
Command::env_saw_path() may be unused on platforms not using posix_sp…
bdrewery File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule liblibc
updated
19 files
+67 −35 | Cargo.lock | |
+1 −1 | Cargo.toml | |
+1 −0 | appveyor.yml | |
+1 −0 | ci/run.sh | |
+8 −2 | libc-test/Cargo.toml | |
+17 −5 | libc-test/build.rs | |
+7 −3 | src/fuchsia/mod.rs | |
+3 −0 | src/lib.rs | |
+119 −0 | src/unix/bsd/apple/mod.rs | |
+76 −0 | src/unix/bsd/freebsdlike/freebsd/mod.rs | |
+3 −0 | src/unix/bsd/mod.rs | |
+15 −0 | src/unix/bsd/netbsdlike/mod.rs | |
+7 −3 | src/unix/mod.rs | |
+464 −0 | src/unix/notbsd/android/mod.rs | |
+239 −0 | src/unix/notbsd/linux/mips/mod.rs | |
+230 −8 | src/unix/notbsd/linux/mod.rs | |
+1 −1 | src/unix/notbsd/linux/other/b64/sparc64.rs | |
+276 −6 | src/unix/notbsd/linux/other/mod.rs | |
+5 −3 | src/unix/notbsd/mod.rs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change this to
_
?(https://doc.rust-lang.org/book/second-edition/ch18-03-pattern-syntax.html)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.