Support homogeneous aggregates for hard-float ARM #43518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard-float ARM targets use the AACPS-VFP ABI, which passes and returns homogeneous float/vector aggregates in the VFP registers. Fixes rust-lang#43329.
|
@bors r+ Thanks! |
|
📌 Commit efc6764 has been approved by |
shepmaster
added
the
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
|
@cuviper do you think we should backport this? |
|
I don't think it's critical, but it's an easy cherry-pick if we want it. Note that it wasn't actually a regression, just a new case added to the existing test, which never would have worked on arm hf before. |
|
Ok, sounds like it's ok to ride the trains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard-float ARM targets use the AAPCS-VFP ABI, which passes and returns
homogeneous float/vector aggregates in the VFP registers.
Fixes #43329.
r? @eddyb