configure: allow distros to disable debuginfo-only-std #43297

infinity0 · 2017-07-17T20:34:10Z

This allows builders to generate debugging information for everything, even in a stable release build. This is useful for distros like Fedora (already carrying a similar patch) and Debian that automatically put all debuginfo in separate "debug symbol" packages.

This commit preserves the default behaviour of switching these on when a non-dev channel is selected, but allows the user to override this via the ./configure command line.

In theory, one could also do this via bootstrap/config.toml but it doesn't work currently due to #43295.

rust-highfive · 2017-07-17T20:34:21Z

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

cuviper · 2017-07-17T20:51:46Z

The implication is that I'll need to disable those explicitly, right?
e.g. --enable-debuginfo --disable-debuginfo-lines --disable-debuginfo-only-std

infinity0 · 2017-07-17T21:26:48Z

Right. Though in Debian I'm only passing --disable-debuginfo-only-std; since debuginfo = true works in config.toml.

I had assumed that --enable-debuginfo-lines is a strictly additive option useful on top of --enable-debuginfo but looking at the code seems it's redundant if debuginfo is already true (either via ./configure or config.toml).

infinity0 · 2017-07-18T14:33:46Z

The failing travis check seems to be due to an HTTP error page being retrieved instead of a script:

$ stamp sh -x -c "$RUN_SCRIPT"
/home/travis/stamp: line 1: syntax error near unexpected token `newline'
/home/travis/stamp: line 1: `<?xml version="1.0" encoding="UTF-8"?>'

40/41 of the other build jobs passed.

arielb1 · 2017-07-18T22:29:59Z

The failing travis check seems to be due to an HTTP error page being retrieved instead of a script:

Sure. Only the "long" travis check is important.

alexcrichton · 2017-07-18T22:31:18Z

@bors: r+

Thanks!

bors · 2017-07-18T22:31:19Z

📌 Commit ffae5de has been approved by alexcrichton

arielb1 · 2017-07-18T22:42:59Z

@bors rollup

bors · 2017-07-19T09:28:43Z

⌛ Testing commit ffae5de with merge bb5ab534d986a0e4e189732fb561c9aa412a0688...

bors · 2017-07-19T09:32:53Z

💔 Test failed - status-appveyor

nagbot-rs · 2017-07-19T14:11:34Z

@bors: retry

…

On Wed, Jul 19, 2017 at 4:33 AM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang/rust/build/1.0.3979> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#43297 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AaPN0C85I6LFrqYQu_VVa9HXW43BJX_Lks5sPc1ZgaJpZM4OagES> . -- You received this message because you are subscribed to the Google Groups "rust-ops" group. To unsubscribe from this group and stop receiving emails from it, send an email to ***@***.*** To post to this group, send email to ***@***.*** To view this discussion on the web visit https://groups.google.com/d/ msgid/rust-ops/rust-lang/rust/pull/43297/c316328489%40github.com <https://groups.google.com/d/msgid/rust-ops/rust-lang/rust/pull/43297/c316328489%40github.com?utm_medium=email&utm_source=footer> . For more options, visit https://groups.google.com/d/optout.

bors · 2017-07-19T14:11:36Z

@nagbot-rs: 🔑 Insufficient privileges: and not in try users

alexcrichton · 2017-07-19T14:14:00Z

@bors: retry

bors · 2017-07-21T12:34:20Z

⌛ Testing commit ffae5de with merge 18d40d93e64191ccc9f2b8fd0c895ace028803e3...

bors · 2017-07-21T13:02:12Z

💔 Test failed - status-travis

TimNN · 2017-07-21T14:23:18Z

@bors retry

Spurious network failure, that seems to have fixed itself

configure: allow distros to disable debuginfo-only-std This allows builders to generate debugging information for everything, even in a stable release build. This is useful for distros like Fedora (already carrying a [similar patch](https://src.fedoraproject.org/cgit/rpms/rust.git/tree/rust-1.16.0-configure-no-override.patch)) and Debian that automatically put all debuginfo in separate "debug symbol" packages. This commit preserves the default behaviour of switching these on when a non-dev channel is selected, but allows the user to override this via the `./configure` command line. In theory, one could also do this via `bootstrap/config.toml` but it doesn't work currently due to rust-lang#43295.

Rollup of 8 pull requests - Successful merges: #43046, #43256, #43280, #43297, #43313, #43319, #43322, #43343 - Failed merges:

configure: allow distros to disable debuginfo-only-std This allows builders to generate debugging information for everything, even in a stable release build. This is useful for distros like Fedora (already carrying a [similar patch](https://src.fedoraproject.org/cgit/rpms/rust.git/tree/rust-1.16.0-configure-no-override.patch)) and Debian that automatically put all debuginfo in separate "debug symbol" packages. This commit preserves the default behaviour of switching these on when a non-dev channel is selected, but allows the user to override this via the `./configure` command line. In theory, one could also do this via `bootstrap/config.toml` but it doesn't work currently due to rust-lang#43295.

Rollup of 11 pull requests - Successful merges: #43297, #43322, #43342, #43361, #43366, #43374, #43379, #43401, #43421, #43428, #43446 - Failed merges:

configure: allow distros to disable debuginfo-only-std

ffae5de

rust-highfive assigned brson Jul 17, 2017

arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 18, 2017

TimNN mentioned this pull request Jul 21, 2017

Rollup of 8 pull requests #43388

Closed

bors added a commit that referenced this pull request Jul 21, 2017

Auto merge of #43388 - TimNN:rollup, r=TimNN

bf51b85

Rollup of 8 pull requests - Successful merges: #43046, #43256, #43280, #43297, #43313, #43319, #43322, #43343 - Failed merges:

Mark-Simulacrum mentioned this pull request Jul 24, 2017

Rollup of 11 pull requests #43454

Merged

bors added a commit that referenced this pull request Jul 24, 2017

Auto merge of #43454 - Mark-Simulacrum:rollup, r=Mark-Simulacrum

598eddf

Rollup of 11 pull requests - Successful merges: #43297, #43322, #43342, #43361, #43366, #43374, #43379, #43401, #43421, #43428, #43446 - Failed merges:

bors merged commit ffae5de into rust-lang:master Jul 24, 2017

configure: allow distros to disable debuginfo-only-std #43297

configure: allow distros to disable debuginfo-only-std #43297

Uh oh!

Conversation

infinity0 commented Jul 17, 2017

Uh oh!

rust-highfive commented Jul 17, 2017

Uh oh!

cuviper commented Jul 17, 2017

Uh oh!

infinity0 commented Jul 17, 2017

Uh oh!

infinity0 commented Jul 18, 2017

Uh oh!

arielb1 commented Jul 18, 2017

Uh oh!

alexcrichton commented Jul 18, 2017

Uh oh!

bors commented Jul 18, 2017

Uh oh!

arielb1 commented Jul 18, 2017

Uh oh!

bors commented Jul 19, 2017

Uh oh!

bors commented Jul 19, 2017

Uh oh!

nagbot-rs commented Jul 19, 2017 via email

Uh oh!

bors commented Jul 19, 2017

Uh oh!

alexcrichton commented Jul 19, 2017

Uh oh!

bors commented Jul 21, 2017

Uh oh!

bors commented Jul 21, 2017

Uh oh!

TimNN commented Jul 21, 2017

Uh oh!

Uh oh!