Skip to content

Add shell=True to bootstrap's subprocess execution #40530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add shell=True to bootstrap's subprocess execution #40530

wants to merge 1 commit into from

Conversation

cengiz-io
Copy link
Contributor

Fixes: #40529

I didn't test this with Windows so, we'll see how it goes.

Thanks!

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Hm this seems suspicious because I have a feeling that shell=True mucks around and spawns a process through a shell rather than the process directly (which is what we want). Notably this is required for ctrl-c to work on Windows.

It looks like the associated issue mentions you're running on Alpine, but I believe the compiler does not currently run successfully there due to the linkage against glibc instead of musl, right?

@cengiz-io cengiz-io closed this Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants