test: Remove NOTE assertions from trace_macros-gate #34824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no NOTE assertions are present I believe they aren't asserted at all, and it looks like the number of NOTEs differs on distcheck vs `make check`, so let's just remove them all. Closes rust-lang#18154
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
r? @brson |
Contributor
|
@bors r+ rollup p=1 |
Collaborator
|
📌 Commit b2d1f7e has been approved by |
Member
Author
|
@bors: rollup- (looks like rollup + p=1 demotes it to the end of the queue) |
Collaborator
bors
added a commit
that referenced
this pull request
Jul 14, 2016
test: Remove NOTE assertions from trace_macros-gate If no NOTE assertions are present I believe they aren't asserted at all, and it looks like the number of NOTEs differs on distcheck vs `make check`, so let's just remove them all. Closes #18154
Contributor
Member
Author
|
Holy cow, that's a serious case of a stale clipboard, thanks @petrochenkov! I'll reopen the issue if this merges and for posterity the actual issue is #34822 |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no NOTE assertions are present I believe they aren't asserted at all, and it
looks like the number of NOTEs differs on distcheck vs
make check, so let'sjust remove them all.
Closes #34822