Skip to content

Conversation

sanxiyn and others added 15 commits May 17, 2016 20:37
Saying that a type *implements* a trait is much more idiomatic than saying it *defines* the trait.
* Change "four eights" to "four u8s"
* Change "a 32" to "a u32"
 - Consume result of thread join()
 - Add link to threading model
Catch thread in example

Since this is an example, the code will be copied by many people and should be over correct.

?r @steveklabnik
Reword the short diagnostic for E0509

Saying that a type *implements* a trait is much more idiomatic than saying it *defines* the trait.
…=arielb1

[MIR] Add PointerCast for Unsize casts of fat pointers.

Fixes rust-lang#33387.

r? @eddyb
Clarify wording in `transmute` example

* Change "four eights" to "four u8s"
* Change "a 32" to "a u32"
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member Author

r? @Manishearth

cc @steveklabnik

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 20, 2016

📌 Commit 4a3ba87 has been approved by Manishearth

@steveklabnik
Copy link
Contributor

@bors: p=1

@bors
Copy link
Collaborator

bors commented May 20, 2016

⌛ Testing commit 4a3ba87 with merge 500e5c1...

bors added a commit that referenced this pull request May 20, 2016
Rollup of 6 pull requests

- Successful merges: #33668, #33676, #33683, #33734, #33739, #33745
- Failed merges: #33578
@bors bors merged commit 4a3ba87 into rust-lang:master May 21, 2016
@bors bors mentioned this pull request May 21, 2016
@GuillaumeGomez GuillaumeGomez deleted the rollup branch May 21, 2016 13:25
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.