Skip to content

Added explanation for E0391 #27318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2015
Merged

Added explanation for E0391 #27318

merged 2 commits into from
Jul 29, 2015

Conversation

soon
Copy link
Contributor

@soon soon commented Jul 27, 2015

Part of #24407

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

This error indicates that some types or traits depends on each other
and therefore could not be constructed properly.

The following example contains circular dependency between two traits:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "contains a circular"

@nrc
Copy link
Member

nrc commented Jul 27, 2015

Thanks for the PR, looks like an improvement. I suggested a few minor grammar improvements. I wonder if you could find an example that has a straightforward solution? That is often informative for readers when they get an error like this. (I'm not exactly sure when this error gets triggers, otherwise I'd suggest something myself).

@soon
Copy link
Contributor Author

soon commented Jul 27, 2015

@nrc There is an issue related to the same error. What do you think, are code samples from that issue easy enough to be presented in the documentation (maybe, with small fixes)?

@nrc
Copy link
Member

nrc commented Jul 28, 2015

Hmm, I don't think that is too useful. In fact, I don't think there is going to be a really informative example here. Looks good as is.

@nrc
Copy link
Member

nrc commented Jul 28, 2015

@bors: r+

@bors
Copy link
Collaborator

bors commented Jul 28, 2015

📌 Commit 9125400 has been approved by nrc

@bors
Copy link
Collaborator

bors commented Jul 28, 2015

⌛ Testing commit 9125400 with merge ba32469...

bors added a commit that referenced this pull request Jul 28, 2015
@bors bors merged commit 9125400 into rust-lang:master Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants