Rollup of PRs in the queue; Saturday #24009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate if the description is available in the rawSearchIndex
The existing impl had the too-strong requirement of `Clone`, when only `ToOwned` was needed.
MacOS X does not ship with Java installed by default. Instead it includes binary stubs that upon execution pop up a message suggesting the installation of the JDK. Since `javac` is only used when `antlr4` is available, it is possible to work around the popup by only probing for `javac` if `antlr4` has been successfully detected (in which case the JDK is probably already installed on the system). Fixes rust-lang#23138.
|
@bors: r+ p=20 |
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
📌 Commit b104d70 has been approved by |
This was brought up in IRC by a confused reader.
bors
added a commit
that referenced
this pull request
Apr 3, 2015
|
💔 Test failed - auto-win-64-nopt-t |
Also: the std_misc feature flag is removed; it's not needed in Beta. Hat tip to @tshepang in rust-lang#23871 Fixes rust-lang#24023
Default is now beta, add nightly in the unstable section
|
It's my fault. I broke that test. I just fixed it in #23976 |
The existing impl had the too-strong requirement of `Clone`, when only `ToOwned` was needed.
…excrichton MacOS X does not ship with Java installed by default. Instead it includes binary stubs that upon execution pop up a message suggesting the installation of the JDK. Since `javac` is only used when `antlr4` is available, it is possible to work around the popup by only probing for `javac` if `antlr4` has been successfully detected (in which case the JDK is probably already installed on the system). Fixes rust-lang#23138.
This was supposed to be a part of rust-lang#23930
Validate if the description is available in the rawSearchIndex
Won't make it for beta, but it's rust-packaging that matters. r? @alexcrichton
…ig, r=alexcrichton Until I can figure out the correct way to configure jemalloc for Bitrig, this patch will correctly disable it. All other build targets remain unchanged.
Kinda hoped I'd spot something else for this PR, but then didn't.
This was brought up in IRC by a confused reader. r? steveklabnik
…veklabnik Also: the std_misc feature flag is removed; it's not needed in Beta. Hat tip to @tshepang in rust-lang#23871 Fixes rust-lang#24023 This PR replaces rust-lang#24024
…ichton Default is now beta, add nightly in the unstable section
|
@bors: r+ force |
|
📌 Commit 29582d3 has been approved by |
|
⌛ Testing commit 29582d3 with merge 69cd145... |
Manishearth
changed the title
|
💔 Test failed - auto-mac-64-opt |
|
@bors: r+ force |
|
📌 Commit b62c110 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.