Skip to content

Add defaulted impls for Send and Sync #23211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 24, 2015
Merged

Add defaulted impls for Send and Sync #23211

merged 4 commits into from
Mar 24, 2015

Conversation

flaper87
Copy link
Contributor

@flaper87 flaper87 commented Mar 9, 2015

@bors
Copy link
Collaborator

bors commented Mar 10, 2015

☔ The latest upstream changes (presumably #23038) made this pull request unmergeable. Please resolve the merge conflicts.

@nikomatsakis
Copy link
Contributor

@flaper87 rebase?

@flaper87 flaper87 force-pushed the oibit-send-and-friends branch from 2c1d7bd to bcc3955 Compare March 10, 2015 13:00
@flaper87
Copy link
Contributor Author

@nikomatsakis r?

flaper87
flaper87 reviewed Mar 11, 2015
View reviewed changes
src/libcore/marker.rs
@@ -39,6 +39,8 @@ pub unsafe trait Send : MarkerTrait {
// empty.
}

impl Send for .. { }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be unsafe

@nikomatsakis
Copy link
Contributor

r+ modulo suggested refactoring

@flaper87 flaper87 force-pushed the oibit-send-and-friends branch from 9135cfa to cc56e71 Compare March 18, 2015 14:55
@nikomatsakis
Copy link
Contributor

@bors r+ cc56e71

@bors
Copy link
Collaborator

bors commented Mar 18, 2015

⌛ Testing commit cc56e71 with merge 2c87f00...

@bors
Copy link
Collaborator

bors commented Mar 18, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Collaborator

bors commented Mar 18, 2015

⌛ Testing commit cc56e71 with merge aedaaee...

@bors
Copy link
Collaborator

bors commented Mar 18, 2015

💔 Test failed - auto-mac-64-opt

@Manishearth
Copy link
Member 

foo.rs:16:5: 16:23 error: default trait implementations are experimental and possibly buggy
foo.rs:16     impl Bar for .. {}
              ^~~~~~~~~~~~~~~~~~
foo.rs:16:23: 16:23 help: add #![feature(optin_builtin_traits)] to the crate attributes to enable
error: aborting due to previous error
make[1]: *** [all] Error 101

@flaper87 flaper87 force-pushed the oibit-send-and-friends branch from cc56e71 to f54a38e Compare March 20, 2015 15:46
@flaper87 flaper87 force-pushed the oibit-send-and-friends branch from f54a38e to 04d5772 Compare March 20, 2015 15:48
@flaper87
Copy link
Contributor Author

@bors: r=nikomatsakis 04d5772

@nikomatsakis
Copy link
Contributor

@bors r+ 04d5772

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

⌛ Testing commit 04d5772 with merge 3549eaf...

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

💔 Test failed - auto-mac-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Mar 23, 2015 at 6:11 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-32-opt
http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4206

—
Reply to this email directly or view it on GitHub
#23211 (comment).

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2015
@alexcrichton
rollup merge of rust-lang#23211: FlaPer87/oibit-send-and-friends
ec1a85a 
Fixes rust-lang#23225

r? @nikomatsakis
@bors
Copy link
Collaborator

bors commented Mar 24, 2015

⌛ Testing commit 04d5772 with merge 40b654d...

@bors
Copy link
Collaborator

bors commented Mar 24, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors bors merged commit 04d5772 into rust-lang:master Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

impl Trait for .. {} does not require a feature gate
5 participants
@flaper87 @bors @nikomatsakis @Manishearth @alexcrichton