Skip to content

Update LLVM to rust-llvm-2015-01-30 #21785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented Jan 30, 2015

No description provided.

These missing calls lead to miscompilations with more recent LLVM
versions.
@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@dotdash
Copy link
Contributor Author

dotdash commented Jan 30, 2015

@lucab Just a heads up because I saw you were likely also working on updating LLVM.

@alexcrichton
Copy link
Member

@bors: r+ faa3eab

@dotdash
Copy link
Contributor Author

dotdash commented Jan 30, 2015

There's a bug left in the debug info part. I updated RustWrapper.cpp to expose the underlyingLLVMMetadataRef type, but the C API expects that to be wrapped in MetadataAsValue. The missing wrapping triggers an assertion compiling a run-pass test. I'll not get to fix that today, so I close this and will open a new PR when that's fixed.

@dotdash dotdash closed this Jan 30, 2015
@lucab
Copy link
Contributor

lucab commented Jan 31, 2015

@dotdash thanks. I'm not touching it right now, but you may want to coordinate with @michaelwoerister on #21512.

@michaelwoerister
Copy link
Member

@dotdash Did you also run into an assertion in LLVMSetMetadata() at https://github.com/rust-lang/rust/blob/master/src/librustc_trans/trans/asm.rs#L153? I wasn't able to find out what the problem was there because everything looked like it should work. But maybe I introduced a bug somewhere along the way myself.

Feel free to cc me if you are discussing any debuginfo problems.

@dotdash
Copy link
Contributor Author

dotdash commented Jan 31, 2015

@michaelwoerister That was a regression in LLVM which I fixed upstream, it's in the new rust-llvm snapshot I made yesterday.

@michaelwoerister
Copy link
Member

@dotdash That's great. I thought that that might be the problem, but overlooked the part where the MDNode indirection was stripped away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants