-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rolling up PRs in the queue #21473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rolling up PRs in the queue #21473
Conversation
There are a large number of places that incorrectly refer to deriving in comments, instead of derives. Fixes rust-lang#20984
Brings the rustdoc man page in sync with the options specified in src/librustdoc/lib.rs. The text was taken verbatim, but I tweaked the order to be (what I think is) somewhat logical.
manual rollup to fix some conflicts and diagnose why the test is failing...
See [https://gist.github.com/0xabad1dea/8870b192fd1758743f66](this document) by @0xabad1dea for the rationale.
rust.nanorc provides syntax highlighting for Rust. An attempt has been made to make the syntax highlighting look good on both dark and light terminals. Issue rust-lang#21286.
Contribution from @look!
File cannot be written, for example, if directory does not exist. Before this commit: ``` % rustc -o nonexistent/program program.rs error: could not write output: No such file or directory ``` With this commit: ``` % rustc -o nonexistent/program program.rs error: could not write output to nonexistent/program.0.o: No such file or directory ``` This is useful when full rust command is not displayed, or when last error is preceded by thousands of warnings.
Increases the delay of the search box to 500ms after key up. I tried adding a three character minimum for setting the delay, but didn't find it very useful. Should close rust-lang#20095
Lets them build with the -dev, -nightly, or snapshot compiler
The reference should be `x`, not `FOO` itself.
…sue-19986-add-append-and-split-off, r=Gankro Please review carefully. Contains unsafe and is my first commit to Rust. Uses ptr::copy_nonoverlapping_memory. Attempts to handle zero-size types correctly.
💔 Test failed - auto-linux-64-x-android-t |
@bors: r+ 9b39b6a p=100 |
@bors: retry |
⌛ Testing commit 9b39b6a with merge 7eb4233... |
💔 Test failed - auto-win-64-nopt-t |
1 similar comment
💔 Test failed - auto-win-64-nopt-t |
⌛ Testing commit 90af723 with merge 524f035... |
cc @michaelwoerister, wasn't sure what to do with this failure so I just ignored the test on windows for now (it's passing locally on linux and OSX) |
💔 Test failed - auto-linux-32-nopt-t |
@bors: retry |
cc @cgaebel, @pczarn, @gankro, this failure seems pretty disturbing (internal hashmap error) |
1 similar comment
@alexcrichton Just ran that test case in a loop with rustc master and can't reproduce. Maybe it was a codegen bug in one of the intermediate patches...? |
I've seen it from time to time before (not sure if it's precisely the same assertion). I suspect that it will be pretty hard to reproduce due to the semi-random nature of |
No description provided.