-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add ManuallyDrop lang item for precise control of destructors #19822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
//! Exposes the `ManuallyDrop` lang item for controlling the exactly what gets dropped within a | ||
//! structure. | ||
|
||
/// A wrapper type that stores data inline without running its destructor when dropped. | ||
#[lang="manually_drop"] | ||
#[experimental] | ||
pub struct ManuallyDrop<T> { | ||
/// Wrapped value | ||
/// | ||
/// This field should not be accessed directly, it is made public for static | ||
/// initializers. | ||
#[unstable] | ||
pub value: T, | ||
} | ||
|
||
impl<T> ManuallyDrop<T> { | ||
/// Construct a new instance of `ManuallyDrop` which will wrap the specified | ||
/// value. | ||
/// | ||
/// All access to the inner value through methods is `unsafe`, and it is | ||
/// highly discouraged to access the fields directly. | ||
/// | ||
/// This function is unsafe for the same reason as `forget`, namely that it | ||
/// prevents the value's destructors from running. | ||
#[experimental] | ||
pub unsafe fn new(value: T) -> ManuallyDrop<T> { | ||
ManuallyDrop { value: value } | ||
} | ||
|
||
/// Gets a mutable pointer to the wrapped value. | ||
/// | ||
/// This function is unsafe as the pointer returned is an unsafe pointer and | ||
/// no guarantees are made about the aliasing of the pointers being handed | ||
/// out in this or other tasks. | ||
#[experimental] | ||
pub unsafe fn get(&self) -> *const T { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The RFC also has this marked safe, fwiw. |
||
&self.value as *const T | ||
} | ||
|
||
/// Unwraps the value | ||
/// | ||
/// This function is unsafe because there is no guarantee that this or other | ||
/// tasks are currently inspecting the inner value. Additionally, the destructor | ||
/// for the inner value is suddenly rescheduled to run. | ||
#[experimental] | ||
pub unsafe fn into_inner(self) -> T { self.value } | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
extern crate core; | ||
|
||
static mut value: uint = 0; | ||
|
||
struct Canary; | ||
|
||
impl Drop for Canary { | ||
fn drop(&mut self) { | ||
unsafe { | ||
value += 1; | ||
} | ||
} | ||
} | ||
|
||
fn main() { | ||
unsafe { | ||
assert_eq!(value, 0); | ||
|
||
{ Canary; } | ||
assert_eq!(value, 1); | ||
|
||
{ core::manually_drop::ManuallyDrop::new(Canary); } | ||
assert_eq!(value, 1); | ||
|
||
{ core::manually_drop::ManuallyDrop::new(Canary).into_inner(); } | ||
assert_eq!(value, 2); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably this should be on
get_mut
, which actually doesn't seem to be implemented?