Repository navigation
std: Export BinarySearchResult - #19287
Merged
Merged
Conversation
At the same time remove the `pub use` of the variants in favor of accessing through the enum type itself. This is a breaking change as the `Found` and `NotFound` variants must now be imported through `BinarySearchResult` instead of just `std::slice`. [breaking-change] Closes rust-lang#19272
Contributor
|
edit: never mind |
Contributor
Contributor
|
In the libcollections facade (and std collections facade) I used globs as much as possible to ensure nothing was missed, and that stuff added to the child modules propagated automatically. Not perfect (as some collections had some special requirements), but it's pretty nice. Actually looking at them again, I probably could have just globbed in all of core_collections into std::collections. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 27, 2014
At the same time remove the `pub use` of the variants in favor of accessing through the enum type itself. This is a breaking change as the `Found` and `NotFound` variants must now be imported through `BinarySearchResult` instead of just `std::slice`. [breaking-change] Closes rust-lang#19271
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the same time remove the
pub useof the variants in favor of accessingthrough the enum type itself. This is a breaking change as the
FoundandNotFoundvariants must now be imported throughBinarySearchResultinstead ofjust
std::slice.[breaking-change]
Closes #19271