fix: fix no resolution for self import in namespaced crates - #160518
Open
JayanAXHF wants to merge 1 commit into
Open
fix: fix no resolution for self import in namespaced crates#160518JayanAXHF wants to merge 1 commit into
JayanAXHF wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
mu001999
reviewed
Aug 5, 2026
| //@ aux-crate:my_api::utils=namespaced_crate_utils.rs | ||
|
|
||
| use alias::utils; | ||
| use my_api as alias; |
Member
There was a problem hiding this comment.
Test should contain trailing self.
Contributor
There was a problem hiding this comment.
Yes, and it would also be good to have test cases for my_api::super and my_api::crate.
Contributor
|
r? petrochenkov |
petrochenkov
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #160512
Add a check for
ident.name == kw::SelfLowerinModuleOrUniformRoot::OpenModulebranch with correctRes