Skip to content

check_consts: exhaustively match on CastKind - #160156

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
RalfJung:cast-kind-const-check
Aug 6, 2026
Merged

check_consts: exhaustively match on CastKind#160156
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
RalfJung:cast-kind-const-check

Conversation

@RalfJung

@RalfJung RalfJung commented Jul 29, 2026

Copy link
Copy Markdown
Member

No description provided.

@rustbot

rustbot commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to the CTFE machinery

cc @oli-obk, @lcnr

Some changes occurred to constck

cc @fee1-dead

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 29, 2026
@rustbot

rustbot commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 74 candidates
  • Random selection from 16 candidates

@RalfJung

RalfJung commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned JohnTitor Aug 5, 2026
oli-obk
oli-obk approved these changes Aug 6, 2026
View reviewed changes

@oli-obk oli-obk left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 192dfdc has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#160156 - RalfJung:cast-kind-const-check, r=…
c3c9170 
…oli-obk

check_consts: exhaustively match on CastKind
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 6, 2026
Closed
@JonathanBrouwer

JonathanBrouwer commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #160609 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 6, 2026
@rust-bors

rust-bors Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#160609), which was unapproved.

View changes since this unapproval

@RalfJung
RalfJung force-pushed the cast-kind-const-check branch from 192dfdc to 71b8456 Compare August 6, 2026 08:15
@rustbot

rustbot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@RalfJung

RalfJung commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

@bors r=oli-obk

@rust-bors

rust-bors Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 71b8456 has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#160156 - RalfJung:cast-kind-const-check, r=…
552929d 
…oli-obk

check_consts: exhaustively match on CastKind
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 6, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#160156 - RalfJung:cast-kind-const-check, r=…
8eb1fef 
…oli-obk

check_consts: exhaustively match on CastKind
This was referenced Aug 6, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Aug 6, 2026
@bors
Auto merge of #160627 - JonathanBrouwer:rollup-gyiU6Wn, r=JonathanBro…
84b36a7 
…uwer

Rollup of 17 pull requests

Successful merges:

 - #159530 (Cap socket send length to c_int::MAX on Apple targets)
 - #159506 (Allow associated const equality constraints with GCA)
 - #160006 (Account for desugaring in method call move errors)
 - #160415 (Split `aarch64-apple{,-macos-26}` => `aarch64-apple{,-macos-26}-{1,2}` jobs)
 - #160464 (fix: Check the fallback map before queueing child in `visible_parent_map` breadth-first search)
 - #160555 (Split `apply_primary_terminator_effect`)
 - #160592 (Suggest if-let chain continuation on unclosed delimiter)
 - #160600 (Avoid the std DLL copy alongside rustc)
 - #160156 (check_consts: exhaustively match on CastKind)
 - #160211 (Rename `#[unroll]` => `#[rustc_unroll]` to mitigate nameres ambiguity)
 - #160304 (Add tests for fixed new solver issues)
 - #160398 (rustc_abi: Add `LayoutData::is_variant_uninhabited` method)
 - #160546 (Update error message in documentation comments)
 - #160568 (Use `VisitorResult` helper macros)
 - #160571 (Add regression test for array type recovery in generic arguments)
 - #160588 (add a test showing polonius alpha is not a subset of datalog polonius)
 - #160617 (Add a suggestion to MissingUnsafeOnExtern diagnostic)
@rust-bors
rust-bors Bot merged commit 852afd5 into rust-lang:main Aug 6, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Aug 6, 2026
rust-timer added a commit that referenced this pull request Aug 6, 2026
@rust-timer
Unrolled build for #160156
15cbfdf 
Rollup merge of #160156 - RalfJung:cast-kind-const-check, r=oli-obk

check_consts: exhaustively match on CastKind
@JonathanBrouwer

JonathanBrouwer commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@rust-timer build 15cbfdf

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (15cbfdf): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.4% [-0.5%, -0.2%] 6
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -4.8% [-6.5%, -3.1%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -4.8% [-6.5%, -3.1%] 2

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.35s -> 460.071s (0.38%)
Artifact size: 398.64 MiB -> 398.66 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

6 participants

@RalfJung @rustbot @JonathanBrouwer @rust-timer @oli-obk @JohnTitor