Rollup of 15 pull requests#158455
Merged
Merged
Conversation
Instead of having to taint both infcx and root_cx, we always just taint infcx (which usually gets automatically tainted from emitting diagnostics), and at the end (before dropping the infcx) we move the taint over to the root_cx
…ame as their parent
convert `FfiPureParser` to a full `AttributeParser` so its `finalize` can check for a sibling `#[ffi_const]` and reject `#[ffi_pure]` during attribute parsing, replacing `check_ffi_pure` in `rustc_passes`.
The parser suggests replacing `=>` with `>=` when it looks like a typo in a comparison, but it skipped the suggestion whenever a comma was an expected token. That excluded closure bodies used as call arguments, such as `iter.position(|x| x => &y)`, which is the case in rust-lang#149805. The comma exclusion was there to avoid suggesting `>=` for a missing comma between match arms, where `=>` is a real arm arrow. Those cases have a close brace in the expected token set, while the comparison cases do not, so gate on the close brace instead of the comma. Fixes rust-lang#149805
…rbid` * Added documentation for allow, cfg, deny, forbid, deprecated and warn attribute Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * add the right deprecated link Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * add the right deprecated link Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix typo Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix phrasing Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix phrasing Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback and add link to rustc book Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>
And while I'm here, improve the tests to check that the unaligned ones are actually unaligned, since `unaligned_volatile_load::<u8>` doesn't actually test anything.
And remove redundant const fn
- const, async, and unsafe functions - const generics, complex types, and where clauses (including impl Tuple)
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #158331. |
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for b8f8eb2 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
rustbot
removed
the
S-waiting-on-author
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing ce9954c (parent) -> 1676160 (this PR) Test differencesShow 576 test diffsStage 1
Stage 2
Additionally, 491 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 16761606d606b6ec4d0c88fc9251670742ad9fd2 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: ce9954c0cf In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Jun 27, 2026
Collaborator
|
Finished benchmarking commit (1676160): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.3%, secondary 0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 486.597s -> 489.966s (0.69%) |
This was referenced Jun 27, 2026
Contributor
Author
Contributor
Author
|
@rustbot label: +perf-regression-triaged |
rustbot
added
the
perf-regression-triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
>=for=>typo in closure and call argument positions #158376 (Suggest>=for=>typo in closure and call argument positions)deprecated,warn,allow,cfg,deny, andforbid#158244 (Attribute docsdeprecated,warn,allow,cfg,deny, andforbid)RerunNonErasederror type mirroringNoSolution, to better track when we're bailing #156246)check_ffi_pureinto the attribute parser #158361 (Movecheck_ffi_pureinto the attribute parser)Vec::into_array#158418 (Eliminate double length check inVec::into_array)NumBuffercomment and replaceilog(10)withilog10()#158448 (CleanupNumBuffercomment and replaceilog(10)withilog10())r? @ghost
Create a similar rollup