Skip to content

Update the rustc_perf submodule#158245

Open
jdonszelmann wants to merge 2 commits into
rust-lang:mainfrom
jdonszelmann:update-rustc-perf
Open

Update the rustc_perf submodule#158245
jdonszelmann wants to merge 2 commits into
rust-lang:mainfrom
jdonszelmann:update-rustc-perf

Conversation

@jdonszelmann

Copy link
Copy Markdown
Contributor

I hope this is a thing that's ok to do, I never update submodules but this one seems to be 8 months old and we got some new benchmarks in the meantime.

r? @Kobzol

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 22, 2026
@rustbot

rustbot commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@jdonszelmann jdonszelmann marked this pull request as ready for review June 22, 2026 11:54
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2026
@rustbot

rustbot commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

@rust-log-analyzer

This comment has been minimized.

@rustbot

rustbot commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 22, 2026
@Mark-Simulacrum

Copy link
Copy Markdown
Member

Note that 'new benchmarks' here largely doesn't matter, we filter down what is actually executed in CI here:

/// The default set of crates for opt-dist to collect LLVM profiles.
pub const LLVM_PGO_CRATES: &[&str] = &[
"syn-2.0.101",
"cargo-0.87.1",
"serde-1.0.219",
"ripgrep-14.1.1",
"regex-automata-0.4.8",
"clap_derive-4.5.32",
"hyper-1.6.0",
];
/// The default set of crates for opt-dist to collect rustc profiles.
pub const RUSTC_PGO_CRATES: &[&str] = &[
"externs",
"ctfe-stress-5",
"cargo-0.87.1",
"token-stream-stress",
"match-stress",
"tuple-stress",
"diesel-2.2.10",
"bitmaps-3.2.1",
"serde-1.0.219-new-solver",
];

But I think it's good to keep the submodule somewhat up to date regardless, to reduce drift / unrelated issues creeping in when we do need to tweak it.

@jdonszelmann

Copy link
Copy Markdown
Contributor Author

well, it matters for local perf runs (x perf) which I do regularly

@jdonszelmann

Copy link
Copy Markdown
Contributor Author

See #t-compiler/contrib-private > Licenses for the discussion on license changes, the upshot it: it's probably fine to do what this PR does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants