Resolver: local/external split of resolve_ident_in_module_non_globs_unadjusted

[LorrensP-2158466]

This PR splits the function resolve_ident_in_module_non_globs_unadjusted into 2 variants:

• one for local modules, which is the same work as before
• other for external modules, which requires less work

In preperations for parallel import resolution and overall resolver refactor.

r? @petrochenkov

[LorrensP-2158466]

@petrochenkov is this what you had in mind? Or was there more to it?

[LorrensP-2158466]

force-pushed with requested changes, @rustbot ready.

[petrochenkov]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 2bc58c1 (2bc58c161c4d707f6eb431aa408cbddad597c7cf)
Base parent: cddcbec (cddcbec198760511240bf0e728193bf4d700acb4)

[rust-timer]

Finished benchmarking commit (2bc58c1): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	2
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	1

Max RSS (memory usage)

Results (primary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.5%	[3.5%, 3.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-3.0%, -1.4%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.0%	[-3.0%, 3.5%]	5

Cycles

Results (primary -1.5%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[2.7%, 4.2%]	3
Improvements ✅ (primary)	-1.5%	[-1.7%, -1.3%]	2
Improvements ✅ (secondary)	-5.0%	[-5.0%, -5.0%]	1
All ❌✅ (primary)	-1.5%	[-1.7%, -1.3%]	2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 505.379s -> 504.424s (-0.19%)
Artifact size: 353.06 MiB -> 353.03 MiB (-0.01%)