Skip to content

Rollup of 2 pull requests#158104

Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
jhpratt:rollup-EAw5CsW
Jun 19, 2026
Merged

Rollup of 2 pull requests#158104
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
jhpratt:rollup-EAw5CsW

Conversation

@jhpratt

@jhpratt jhpratt commented Jun 18, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

amandasystems and others added 4 commits June 18, 2026 16:19
@amandasystems
RegionValues: disable unnecessary range check
dbf6d75 
Currently, when adding liveness points to region values
in the `RegionValues` struct, the locations of the points
are checked for ranges. This is unnecessarily cautious because
they always are in range by construction.

This adds documentation (including debug assertions) to make this
clearer and removes the checks, which should have a strictly
positive impact on performance.
@cuviper
Initialize directly in From<T> for OnceLock<T>
f57fb8e 
There's no need to jump through all the hoops of `set` when we are
creating a new `OnceLock` from scratch.
@jhpratt
Rollup merge of rust-lang#158026 - amandasystems:region-values-point-…
72979c1 
…no-range-check, r=petrochenkov

`RegionValues`: disable unnecessary range check

Currently, when adding liveness points to region values in the `RegionValues` struct, the locations of the points are checked for ranges. This is unnecessarily cautious because they always are in range by construction. The docstring for the method used in the checks suggests that it was designed for underlying bit sets that currently aren't used for this.

This adds documentation (including debug assertions) to make this clearer and removes the checks, which should have a strictly positive impact on performance.
@jhpratt
Rollup merge of rust-lang#158101 - cuviper:once_lock-from, r=tgross35
1191a9d 
Initialize directly in `From<T> for OnceLock<T>`

There's no need to jump through all the hoops of `set` when we are
creating a new `OnceLock` from scratch.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Jun 18, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 18, 2026
@jhpratt

jhpratt commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=5

@rust-bors

rust-bors Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1191a9d has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 19, 2026
@rust-bors

rust-bors Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 8m 12s
Pushing 8c3f167 to main...

@rust-bors rust-bors Bot merged commit 8c3f167 into rust-lang:main Jun 19, 2026
14 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 19, 2026
@rust-timer

rust-timer commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#158026 RegionValues: disable unnecessary range check eb4f67d46fc493c678d91e9c3a6a57b0a403b2c4 (link)
#158101 Initialize directly in From<T> for OnceLock<T> 758152e0fd6a096bd0c66db25d9ea84248947967 (link)

previous master: bc2112ed56

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing bc2112e (parent) -> 8c3f167 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8c3f16724631ab8ed640567c0353687f85ad05f9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-miri: 54m 4s -> 1h 32m (+71.9%)
  2. dist-powerpc64-linux-musl: 1h 3m -> 1h 31m (+44.3%)
  3. dist-x86_64-llvm-mingw: 1h 27m -> 1h 55m (+31.9%)
  4. x86_64-gnu-gcc-core-tests: 10m 58s -> 7m 37s (-30.5%)
  5. dist-aarch64-linux: 2h 27m -> 1h 43m (-29.6%)
  6. x86_64-msvc-2: 2h 28m -> 1h 50m (-25.4%)
  7. x86_64-gnu-pre-stabilization: 33m 5s -> 25m 38s (-22.5%)
  8. dist-powerpc64-linux-gnu: 1h 33m -> 1h 13m (-21.6%)
  9. dist-ohos-aarch64: 1h 17m -> 1h 2m (-20.4%)
  10. aarch64-apple: 3h 1m -> 2h 35m (-14.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (8c3f167): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.3% [-0.3%, -0.3%] 2
Improvements ✅
(secondary)		 -0.2% [-0.3%, -0.2%] 6
All ❌✅ (primary) -0.3% [-0.3%, -0.3%] 2

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary 5.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.5% [5.5%, 5.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.2%, -0.1%] 8
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.2%, -0.1%] 8

Bootstrap: 482.188s -> 480.598s (-0.33%)
Artifact size: 391.12 MiB -> 390.74 MiB (-0.10%)

@jhpratt jhpratt deleted the rollup-EAw5CsW branch June 19, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jhpratt @rust-timer @rustbot @amandasystems @cuviper