Remove old MinGW workaround#158021
Draft
mati865 wants to merge 2 commits into
Draft
Conversation
Before mingw-w64/mingw-w64@dbfdf80 mkstemp used by Binutils was not sufficiently collision resilient and that led to CI errors for us. Our new baseline mingw-w64 toolchain's Binutils are built using mingw-w64 with the fix: niXman/mingw-builds#682 So, we should be able to get rid of it.
rustbot
added
A-CI
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
Remove old MinGW workaround try-job: *i686-mingw try-job: x86_64-mingw
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
Remove old MinGW workaround try-job: *i686-mingw try-job: *x86_64-mingw*
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
Remove old MinGW workaround try-job: *i686-mingw try-job: x86_64-mingw
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
Remove old MinGW workaround try-job: *i686-mingw try-job: *x86_64-mingw*
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
@bors try jobs=*i686-mingw,x86_64-mingw |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
Remove old MinGW workaround try-job: *i686-mingw try-job: *x86_64-mingw*
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before https://github.com/mingw-w64/mingw-w64/commit/ mkstemp used by Binutils was not sufficiently collision resilient and that led to CI errors for us.
Our new baseline mingw-w64 toolchain's Binutils are built using mingw-w64 with the fix: niXman/mingw-builds#682
So, we should be able to get rid of it.