Rollup of 12 pull requests#152208
Closed
JonathanBrouwer wants to merge 29 commits intorust-lang:mainfrom
Closed
Conversation
It contains the `Cursor` type and an `impl Cursor` block with a few methods. But there is a larger `impl Cursor` block in the crate root. The only other thing in the `cursor` module is the simple `FrontmatterAllowed` type. So this commit just moves everything in the `cursor` module (which isn't much) into the crate root.
Every diagnostic struct in `rustc_parse` is in the `errors` module, except for `ForbiddenLetReason` and `MisspelledKw`. There's no good reason for this, and presumably it is just an accidental inconsistency. This commit moves them into `errors`.
From the `parser` module to the `errors` module, which is where most of its uses are. This means the `errors` module no longer depends on the `parser` module, removing a cyclic dependency between the two modules.
Mark match arms in try and for as being from desugarings. Some of the arms created by these desugarings have an expression which isn't marked as coming from the desugaring. e.g. try generates `Continue(val) => val` where the expression has the span of the original parameter (done for diagnostic purposes). Since the arm created just used that span they end up without a desugaring mark unnecessarily. This is only a minor annoyance with some work I'm doing in clippy.
Minor structural improvements Some small cleanups. r? @davidtwco
…rtn, r=davidtwco fix refining_impl_trait suggestion with return_type_notation using `#![feature(return_type_notation)] `on top of `refining_impl_trait` made the lint suggest a pretty wild “wrap the body in `<Self as Trait>::f(..)”` fix instead of the simple “just copy the return type from the trait”. this patch makes the lint always suggest the plain return-type replacement based on the trait signature (by grabbing the original snippet when possible), so you don’t get RTN-style desugarings in the help new test here fixes rust-lang#151663
…r=lqd Convert to inline diagnostics in `rustc_borrowck` For rust-lang#151366 r? @jdonszelmann
…ction2, r=GuillaumeGomez Convert to inline diagnostics in `rustc_trait_selection` For rust-lang#151366 r? @jdonszelmann
…ks, r=BoxyUwU Consolidate type const checks on `tcx.is_type_const` A little bit of cleanup; explanation can be found in the reporting issue. Fixes rust-lang#152124 r? BoxyUwU
Fix typos in riscv64a23-unknown-linux-gnu.md
…visibility, r=JonathanBrouwer Port `rustc_effective_visibility` to the new attribute parser r? @JonathanBrouwer
…ckport-zulip-msg, r=jieyouxu update compiler stable backport zulip msg I'd like to update the message when stable backports (for t-compiler) Zulip topics are opened. Stable backports mention the channel i.e. also people who might not have context, example: [#t-compiler/backports > rust-lang#150590: stable-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23150590.3A.20stable-nominated/near/569989784) Beta backports mention author+reviewer (which fits better), example: [#t-compiler/backports > rust-lang#151896: beta-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23151896.3A.20beta-nominated/near/571171604) This patch makes the `stable` backport opening message just like the `beta` backport one. Thanks
Port rustc_abi to the attribute parser Tracking issue: rust-lang#131229 This attribute either dumps the abi info for functions (debug arg) or if you put it on a pair of fn ptr's it checks they match (assert_eq arg) r? @JonathanBrouwer
…jieyouxu update openmp/offload builds to LLVM 22, Part 1 This part of the update of OpenMP/Offload to LLVM 22 does not depend on a backport in the future LLVM release candidate 3. Let's therefore merge it first, to unblock existing users/developers. r? @jieyouxu
chore: clearify tidy's error message it took me a while to realize this error was due to the name of the file, not the file's content
rustbot
added
A-attributes
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_borrowck#152107 (Convert to inline diagnostics inrustc_borrowck)rustc_trait_selection#152117 (Convert to inline diagnostics inrustc_trait_selection)tcx.is_type_const#152136 (Consolidate type const checks ontcx.is_type_const)rustc_effective_visibilityto the new attribute parser #152170 (Portrustc_effective_visibilityto the new attribute parser)r? @ghost
Create a similar rollup