Convert to inline diagnostics in `rustc_const_eval` by GuillaumeGomez · Pull Request #152186 · rust-lang/rust

GuillaumeGomez · 2026-02-05T21:27:19Z

rustbot · 2026-02-05T21:27:23Z

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to constck

⚠️ #[rustc_intrinsic_const_stable_indirect] controls whether intrinsics can be exposed to stable const
code; adding it needs t-lang approval.

cc @rust-lang/wg-const-eval

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

compiler/rustc_const_eval/src/errors.rs

compiler/rustc_const_eval/src/interpret/call.rs

tests/ui/consts/const-try-feature-gate.stderr

JonathanBrouwer · 2026-02-06T09:12:44Z

@rustbot author

rustbot · 2026-02-06T21:56:11Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-02-06T22:17:45Z

@bors r+ rollup

rust-bors · 2026-02-06T22:17:49Z

📌 Commit c682902 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…onst_eval, r=JonathanBrouwer Convert to inline diagnostics in `rustc_const_eval` Part of rust-lang#151366. r? @JonathanBrouwer

JonathanBrouwer · 2026-02-06T22:24:40Z

compiler/rustc_const_eval/src/const_eval/machine.rs

-                        fluent::const_eval_invalid_align_details,
+                        inline_fluent!(
+                            "invalid align passed to `{$name}`: {$align} is {$err_kind ->
+    [not_power_of_two] not a power of 2


These are ugly but I will fix this in a separate PR for all crates simultaneously :)

@JonathanBrouwer

…onst_eval, r=JonathanBrouwer Convert to inline diagnostics in `rustc_const_eval` Part of rust-lang#151366. r? @JonathanBrouwer

…uwer Rollup of 5 pull requests Successful merges: - #149960 (add `unreachable_cfg_select_predicates` lint) - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152186 (Convert to inline diagnostics in `rustc_const_eval`) - #152234 (Dont strip const blocks in array lengths) - #152243 (Use relative paths for std links in rustc-docs)

…uwer Rollup of 4 pull requests Successful merges: - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152186 (Convert to inline diagnostics in `rustc_const_eval`) - #152234 (Dont strip const blocks in array lengths) - #152243 (Use relative paths for std links in rustc-docs)

@JonathanBrouwer

Rollup merge of #152186 - GuillaumeGomez:inline-diag-rustc_const_eval, r=JonathanBrouwer Convert to inline diagnostics in `rustc_const_eval` Part of #151366. r? @JonathanBrouwer

JonathanBrouwer · 2026-02-07T08:20:33Z

@rust-timer build 3f41e19

rust-timer · 2026-02-07T10:02:00Z

Finished benchmarking commit (3f41e19): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-1.8%, -0.4%]	7
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -5.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.3%	[-5.3%, -5.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-5.3%	[-5.3%, -5.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.536s -> 474.919s (0.08%)
Artifact size: 397.98 MiB -> 398.01 MiB (0.01%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 5, 2026

rustbot assigned JonathanBrouwer Feb 5, 2026

RalfJung reviewed Feb 5, 2026

View reviewed changes

compiler/rustc_const_eval/src/errors.rs Show resolved Hide resolved

RalfJung reviewed Feb 5, 2026

View reviewed changes

compiler/rustc_const_eval/src/interpret/call.rs Outdated Show resolved Hide resolved

JonathanBrouwer reviewed Feb 5, 2026

View reviewed changes

tests/ui/consts/const-try-feature-gate.stderr Show resolved Hide resolved

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Feb 5, 2026

Tracking issue for MCP 959: Remove the fluent files #151366

Open

3 tasks

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2026

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the inline-diag-rustc_const_eval branch from 3225771 to d575741 Compare February 6, 2026 21:24

Convert to inline diagnostics in rustc_const_eval

c682902

GuillaumeGomez force-pushed the inline-diag-rustc_const_eval branch from 543765c to c41480e Compare February 6, 2026 21:56

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the inline-diag-rustc_const_eval branch 2 times, most recently from 02277e3 to c682902 Compare February 6, 2026 22:15

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 6, 2026

JonathanBrouwer mentioned this pull request Feb 6, 2026

Rollup of 4 pull requests #152257

Closed

JonathanBrouwer reviewed Feb 6, 2026

View reviewed changes

JonathanBrouwer mentioned this pull request Feb 6, 2026

Rollup of 5 pull requests #152260

Closed

JonathanBrouwer mentioned this pull request Feb 7, 2026

Rollup of 4 pull requests #152264

Merged

rust-bors bot merged commit a66d0f8 into rust-lang:main Feb 7, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 7, 2026

rust-timer added a commit that referenced this pull request Feb 7, 2026

Unrolled build for #152186

3f41e19

Rollup merge of #152186 - GuillaumeGomez:inline-diag-rustc_const_eval, r=JonathanBrouwer Convert to inline diagnostics in `rustc_const_eval` Part of #151366. r? @JonathanBrouwer

This comment has been minimized.

Sign in to view

GuillaumeGomez deleted the inline-diag-rustc_const_eval branch February 7, 2026 16:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Convert to inline diagnostics in `rustc_const_eval`#152186

Convert to inline diagnostics in `rustc_const_eval`#152186
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
GuillaumeGomez:inline-diag-rustc_const_eval

GuillaumeGomez commented Feb 5, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Feb 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Feb 6, 2026

Uh oh!

This comment has been minimized.

rustbot commented Feb 6, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Feb 6, 2026

Uh oh!

rust-bors bot commented Feb 6, 2026

Uh oh!

JonathanBrouwer Feb 6, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Feb 7, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Feb 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

GuillaumeGomez commented Feb 5, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Feb 6, 2026

Uh oh!

This comment has been minimized.

rustbot commented Feb 6, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Feb 6, 2026

Uh oh!

rust-bors bot commented Feb 6, 2026

Uh oh!

JonathanBrouwer Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JonathanBrouwer commented Feb 7, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Feb 7, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

GuillaumeGomez commented Feb 5, 2026 •

edited by rustbot

Loading