Port rustc_effective_visibility to the new attribute parser#152170
Open
jdonszelmann wants to merge 1 commit intorust-lang:mainfrom
Open
Port rustc_effective_visibility to the new attribute parser#152170jdonszelmann wants to merge 1 commit intorust-lang:mainfrom
rustc_effective_visibility to the new attribute parser#152170jdonszelmann wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_attr_parsing Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt
cc @rust-lang/wg-const-eval Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
rustbot
added
A-attributes
Contributor
Author
|
let's do this one separately, it's unrelated |
Contributor
Author
|
based on it anyway, since we'll get conflicts. They're next to eachother in a file. |
9 tasks
Contributor
Author
|
unlinked them after all |
jdonszelmann
force-pushed
the
port-rustc-effective-visibility
branch
from
58d3317 to
4935b73
Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
port-rustc-effective-visibility
branch
from
4935b73 to
9112039
Compare
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 5, 2026
…visibility, r=JonathanBrouwer Port `rustc_effective_visibility` to the new attribute parser r? @JonathanBrouwer
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 5, 2026
…visibility, r=JonathanBrouwer Port `rustc_effective_visibility` to the new attribute parser r? @JonathanBrouwer
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…uwer Rollup of 9 pull requests Successful merges: - #151278 (Provide more context on trait bounds being unmet due to imperfect derive) - #151955 (escape symbol names in global asm) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152170 (Port `rustc_effective_visibility` to the new attribute parser)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…uwer Rollup of 9 pull requests Successful merges: - #151278 (Provide more context on trait bounds being unmet due to imperfect derive) - #151955 (escape symbol names in global asm) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152170 (Port `rustc_effective_visibility` to the new attribute parser)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @JonathanBrouwer