Move impl Interner for TyCtxt to its own submodule#152148
Open
Zalathar wants to merge 3 commits intorust-lang:mainfrom
Open
Move impl Interner for TyCtxt to its own submodule#152148Zalathar wants to merge 3 commits intorust-lang:mainfrom
impl Interner for TyCtxt to its own submodule#152148Zalathar wants to merge 3 commits intorust-lang:mainfrom
Conversation
Requiring `fn` in the macro syntax makes it a little more obvious that the macro declares functions with those names, and makes them easier to grep for.
Collaborator
|
rustbot has assigned @petrochenkov. Use |
Member
Author
|
I had been looking into whether it's feasible to extract |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This impl is several hundred lines of mostly self-contained, mostly boilerplate code that can be extracted out of the dauntingly large
rustc_middle::ty::contextmodule.rustc_type_ir#97287.There should be no change to compiler behaviour.