Don't ICE on layout error in vtable computation by meithecatte · Pull Request #152120 · rust-lang/rust

meithecatte · 2026-02-04T16:59:38Z

Fixes #152030.

Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?

rustbot · 2026-02-04T16:59:43Z

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_middle/src/ty/vtable.rs

petrochenkov · 2026-02-09T14:16:17Z

Does it make sense to also include the original testcase?

Yes, let's add that test case as well.
@rustbot author

rustbot · 2026-02-09T14:16:22Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

meithecatte · 2026-02-10T14:37:04Z

Now with more tests. Still using match instead of let else because I don't see how to make a let else work in that context.

@rustbot ready

petrochenkov · 2026-02-10T14:38:39Z

@bors r+

rust-bors · 2026-02-10T14:38:43Z

📌 Commit 58335d6 has been approved by petrochenkov

It is now in the queue for this repository.

…etrochenkov Don't ICE on layout error in vtable computation Fixes rust-lang#152030. Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?

…uwer Rollup of 13 pull requests Successful merges: - #149937 (try enabling `linker-messages` by default again) - #151733 (Use function shims to make sure EII works on apple targets) - #152120 (Don't ICE on layout error in vtable computation) - #152419 (Move more query system code) - #152431 (Restrict the set of things that const stability can be applied to) - #152436 (Reenable a GCI+mGCA+GCPT test case) - #151142 (Support ADT types in type info reflection) - #152021 (Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2) - #152146 (mGCA: Add associated const type check) - #152372 (style: remove unneeded trailing commas) - #152383 (BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable) - #152397 (Update books) - #152441 (Fix typos and grammar in top-level and src/doc documentation)

…etrochenkov Don't ICE on layout error in vtable computation Fixes rust-lang#152030. Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?

Rollup of 10 pull requests Successful merges: - #152120 (Don't ICE on layout error in vtable computation) - #152419 (Move more query system code) - #152431 (Restrict the set of things that const stability can be applied to) - #152436 (Reenable a GCI+mGCA+GCPT test case) - #152021 (Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2) - #152146 (mGCA: Add associated const type check) - #152372 (style: remove unneeded trailing commas) - #152383 (BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable) - #152397 (Update books) - #152441 (Fix typos and grammar in top-level and src/doc documentation)

matthiaskrgr · 2026-02-11T12:47:53Z

@bors r-
#152475 (comment)

rust-bors · 2026-02-11T12:48:01Z

Commit 58335d6 has been unapproved.

This PR was contained in a rollup (#152475), which was also unapproved.

rustbot · 2026-02-12T21:01:44Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

meithecatte · 2026-02-12T22:08:38Z

Sorry for the broken rollup, I had mistakenly assumed that debuginfo=0 is the default for the test suite. Should be fixed now.

Should we do a try build of x86_64-gnu-debug just in case?

meithecatte · 2026-02-14T04:05:12Z

ah, @rustbot ready

petrochenkov · 2026-02-14T10:16:26Z

@bors r+

rust-bors · 2026-02-14T10:16:28Z

📌 Commit e098327 has been approved by petrochenkov

It is now in the queue for this repository.

…etrochenkov Don't ICE on layout error in vtable computation Fixes rust-lang#152030. Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?

…uwer Rollup of 7 pull requests Successful merges: - #152001 (mGCA: Validate const literal against expected type) - #152120 (Don't ICE on layout error in vtable computation) - #152512 (core: Implement feature `float_exact_integer_constants`) - #152531 (`proc_macro::bridge`: simplify `ExecutionStrategy` and `DispatcherTrait`) - #152577 (Port #[rustc_proc_macro_decls] to the new attribute parser.) - #152590 (DepGraphQuery: correctly skip adding edges with not-yet-added nodes) - #152612 (Rename `inline_fluent!` to `msg!`)

…uwer Rollup of 8 pull requests Successful merges: - #152618 (stdarch subtree update) - #152001 (mGCA: Validate const literal against expected type) - #152120 (Don't ICE on layout error in vtable computation) - #152531 (`proc_macro::bridge`: simplify `ExecutionStrategy` and `DispatcherTrait`) - #152577 (Port #[rustc_proc_macro_decls] to the new attribute parser.) - #152570 (Port #[rustc_test_marker] to the attribute parser) - #152590 (DepGraphQuery: correctly skip adding edges with not-yet-added nodes) - #152612 (Rename `inline_fluent!` to `msg!`)

Rollup merge of #152120 - meithecatte:push-ltvwvkqrytno, r=petrochenkov Don't ICE on layout error in vtable computation Fixes #152030. Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?

…uwer Rollup of 8 pull requests Successful merges: - rust-lang/rust#152618 (stdarch subtree update) - rust-lang/rust#152001 (mGCA: Validate const literal against expected type) - rust-lang/rust#152120 (Don't ICE on layout error in vtable computation) - rust-lang/rust#152531 (`proc_macro::bridge`: simplify `ExecutionStrategy` and `DispatcherTrait`) - rust-lang/rust#152577 (Port #[rustc_proc_macro_decls] to the new attribute parser.) - rust-lang/rust#152570 (Port #[rustc_test_marker] to the attribute parser) - rust-lang/rust#152590 (DepGraphQuery: correctly skip adding edges with not-yet-added nodes) - rust-lang/rust#152612 (Rename `inline_fluent!` to `msg!`)

rustbot assigned petrochenkov Feb 4, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 4, 2026

petrochenkov reviewed Feb 9, 2026

View reviewed changes

compiler/rustc_middle/src/ty/vtable.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2026

meithecatte force-pushed the push-ltvwvkqrytno branch from 76f5ec8 to 58335d6 Compare February 10, 2026 14:33

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2026

JonathanBrouwer mentioned this pull request Feb 10, 2026

Rollup of 10 pull requests #152442

Closed

JonathanBrouwer mentioned this pull request Feb 10, 2026

Rollup of 13 pull requests #152451

Closed

matthiaskrgr mentioned this pull request Feb 10, 2026

Rollup of 12 pull requests #152454

Closed

matthiaskrgr mentioned this pull request Feb 11, 2026

Rollup of 11 pull requests #152473

Closed

matthiaskrgr mentioned this pull request Feb 11, 2026

Rollup of 10 pull requests #152475

Closed

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2026

tmiasko mentioned this pull request Feb 11, 2026

rustc_monomorphize: Skip vtable alloc collection in the pre-optimisation MentionedItems mode #152462

Open

Don't ICE on layout error in vtable computation

e098327

meithecatte force-pushed the push-ltvwvkqrytno branch from 58335d6 to e098327 Compare February 12, 2026 21:01

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2026

JonathanBrouwer mentioned this pull request Feb 14, 2026

Rollup of 5 pull requests #152614

Closed

JonathanBrouwer mentioned this pull request Feb 14, 2026

Rollup of 7 pull requests #152616

Closed

JonathanBrouwer mentioned this pull request Feb 14, 2026

Rollup of 8 pull requests #152627

Merged

rust-bors bot merged commit 2c4656a into rust-lang:main Feb 14, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 14, 2026

Uh oh!

Conversation

meithecatte commented Feb 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 4, 2026

Uh oh!

Uh oh!

petrochenkov commented Feb 9, 2026

Uh oh!

rustbot commented Feb 9, 2026

Uh oh!

meithecatte commented Feb 10, 2026

Uh oh!

petrochenkov commented Feb 10, 2026

Uh oh!

rust-bors bot commented Feb 10, 2026

Uh oh!

matthiaskrgr commented Feb 11, 2026

Uh oh!

rust-bors bot commented Feb 11, 2026

Uh oh!

rustbot commented Feb 12, 2026

Uh oh!

meithecatte commented Feb 12, 2026

Uh oh!

meithecatte commented Feb 14, 2026

Uh oh!

petrochenkov commented Feb 14, 2026

Uh oh!

rust-bors bot commented Feb 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

meithecatte commented Feb 4, 2026 •

edited by rustbot

Loading