Skip to content

Remove Deref<Target = TyCtxt> from QueryCtxt#151626

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Zalathar:qcx-deref
Jan 27, 2026
Merged

Remove Deref<Target = TyCtxt> from QueryCtxt#151626
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Zalathar:qcx-deref

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Jan 25, 2026

Explicitly writing self.tcx is easy enough, and lets us remove a bit of non-essential deref magic.

@Zalathar
Remove Deref<Target = TyCtxt> from QueryCtxt
4b8fc13 
Explicitly writing `self.tcx` is easy enough, and lets us remove a bit of
non-essential deref magic.
@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 25, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 25, 2026

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tiif
Copy link
Member

tiif commented Jan 26, 2026

r? tiif

@rustbot rustbot assigned tiif and unassigned BoxyUwU Jan 26, 2026
@tiif
Copy link
Member

tiif commented Jan 26, 2026

This looks better than before, thanks! :)

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 26, 2026

📌 Commit 4b8fc13 has been approved by tiif

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 26, 2026
@Zalathar
Rollup merge of rust-lang#151626 - Zalathar:qcx-deref, r=tiif
3a5239b 
Remove `Deref<Target = TyCtxt>` from `QueryCtxt`

Explicitly writing `self.tcx` is easy enough, and lets us remove a bit of non-essential deref magic.
@Zalathar Zalathar mentioned this pull request Jan 26, 2026
Closed
@Zalathar
Copy link
Member Author

Zalathar commented Jan 26, 2026

(Unrelated to this PR specifically; I'm just investigating a potential CI-duration regression in #151667.)

@bors try jobs=aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 26, 2026
@bors
Auto merge of #151626 - Zalathar:qcx-deref, r=<try>
4959ca3 
Remove `Deref<Target = TyCtxt>` from `QueryCtxt`


try-job: aarch64-apple
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 26, 2026
@Zalathar
Rollup merge of rust-lang#151626 - Zalathar:qcx-deref, r=tiif
cb6ac07 
Remove `Deref<Target = TyCtxt>` from `QueryCtxt`

Explicitly writing `self.tcx` is easy enough, and lets us remove a bit of non-essential deref magic.
@Zalathar Zalathar mentioned this pull request Jan 26, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 26, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151626 - Zalathar:qcx-deref, r=tiif
abc45d8 
Remove `Deref<Target = TyCtxt>` from `QueryCtxt`

Explicitly writing `self.tcx` is easy enough, and lets us remove a bit of non-essential deref magic.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 26, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 26, 2026
@bors
Auto merge of #151681 - Zalathar:rollup-2s4yN8G, r=Zalathar
cdf9d15 
Rollup of 3 pull requests

Successful merges:

 - #151676 (Do not return incorrectly constrained opaques in `method_autoderef_steps`)
 - #151626 (Remove `Deref<Target = TyCtxt>` from `QueryCtxt`)
 - #151661 (Suggest changing `iter`/`into_iter` when the other was meant)
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 26, 2026

☀️ Try build successful (CI)
Build commit: 4959ca3 (4959ca3a3b04c3f0440c11cdec149f17b2154e03, parent: 0462e8f7e51f20692b02d68efee68bb28a6f4457)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 26, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151626 - Zalathar:qcx-deref, r=tiif
ebfeb0a 
Remove `Deref<Target = TyCtxt>` from `QueryCtxt`

Explicitly writing `self.tcx` is easy enough, and lets us remove a bit of non-essential deref magic.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 26, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 26, 2026
@bors
Auto merge of #151687 - JonathanBrouwer:rollup-b6J6AJQ, r=JonathanBro…
36aca3d 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #151137 (checksum-freshness: Fix invalid checksum calculation for binary files)
 - #148187 (Remove uses of `&mut CmResolver`)
 - #151626 (Remove `Deref<Target = TyCtxt>` from `QueryCtxt`)
 - #151661 (Suggest changing `iter`/`into_iter` when the other was meant)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 26, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 26, 2026
@bors
Auto merge of #151701 - JonathanBrouwer:rollup-PvhvBqX, r=JonathanBro…
19e806e 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #151290 (Recover from struct literals with placeholder or empty path)
 - #148187 (Remove uses of `&mut CmResolver`)
 - #151368 (Rustdoc performance improvements)
 - #151374 (some more rustc_borrowck cleanups)
 - #151536 (Fix sanitizer target builds on CI)
 - #151626 (Remove `Deref<Target = TyCtxt>` from `QueryCtxt`)
 - #151661 (Suggest changing `iter`/`into_iter` when the other was meant)
rust-bors bot pushed a commit that referenced this pull request Jan 26, 2026
@bors
Auto merge of #151701 - JonathanBrouwer:rollup-PvhvBqX, r=JonathanBro…
f78d312 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #151290 (Recover from struct literals with placeholder or empty path)
 - #148187 (Remove uses of `&mut CmResolver`)
 - #151368 (Rustdoc performance improvements)
 - #151374 (some more rustc_borrowck cleanups)
 - #151536 (Fix sanitizer target builds on CI)
 - #151626 (Remove `Deref<Target = TyCtxt>` from `QueryCtxt`)
 - #151661 (Suggest changing `iter`/`into_iter` when the other was meant)
rust-bors bot pushed a commit that referenced this pull request Jan 26, 2026
@bors
Auto merge of #151701 - JonathanBrouwer:rollup-PvhvBqX, r=JonathanBro…
ff72201 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #151290 (Recover from struct literals with placeholder or empty path)
 - #148187 (Remove uses of `&mut CmResolver`)
 - #151368 (Rustdoc performance improvements)
 - #151374 (some more rustc_borrowck cleanups)
 - #151536 (Fix sanitizer target builds on CI)
 - #151626 (Remove `Deref<Target = TyCtxt>` from `QueryCtxt`)
 - #151661 (Suggest changing `iter`/`into_iter` when the other was meant)
rust-bors bot pushed a commit that referenced this pull request Jan 26, 2026
@bors
Auto merge of #151701 - JonathanBrouwer:rollup-PvhvBqX, r=JonathanBro…
b3cda16 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #151290 (Recover from struct literals with placeholder or empty path)
 - #148187 (Remove uses of `&mut CmResolver`)
 - #151368 (Rustdoc performance improvements)
 - #151374 (some more rustc_borrowck cleanups)
 - #151536 (Fix sanitizer target builds on CI)
 - #151626 (Remove `Deref<Target = TyCtxt>` from `QueryCtxt`)
 - #151661 (Suggest changing `iter`/`into_iter` when the other was meant)
@rust-bors rust-bors bot merged commit e1760d4 into rust-lang:main Jan 27, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 27, 2026
rust-timer added a commit that referenced this pull request Jan 27, 2026
@rust-timer
Unrolled build for #151626
82df68e 
Rollup merge of #151626 - Zalathar:qcx-deref, r=tiif

Remove `Deref<Target = TyCtxt>` from `QueryCtxt`

Explicitly writing `self.tcx` is easy enough, and lets us remove a bit of non-essential deref magic.
@Zalathar Zalathar deleted the qcx-deref branch January 27, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tiif tiif

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Zalathar @rustbot @tiif @BoxyUwU