Skip to content

fix(build-manifest)!: limit rustc-docs to current host target in the manifest #151416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 21, 2026
Merged

fix(build-manifest)!: limit rustc-docs to current host target in the manifest #151416

rust-bors merged 1 commit into from
Jan 21, 2026
+2 −1

Conversation

@rami3l
Copy link
Member

@rami3l rami3l commented Jan 20, 2026 •
edited
Loading

Part of rust-lang/rustup#3717.

This is a continuation of #151080, where enabling "target fallback" allows rustup +nightly component add rustc-docs to execute correctly on all major hosts, but as a byproduct of this change, today we have:

> rustc +nightly --version
rustc 1.95.0-nightly (d940e5684 2026-01-19)

> rustup +nightly component list | rg rustc-docs
rustc-docs-aarch64-apple-darwin
rustc-docs-aarch64-pc-windows-gnullvm
rustc-docs-aarch64-pc-windows-msvc
rustc-docs-aarch64-unknown-linux-gnu
[..]
rustc-docs-x86_64-unknown-linux-gnu
rustc-docs-x86_64-unknown-linux-musl
rustc-docs-x86_64-unknown-netbsd

This is actually okay because most of them are just aliases to rustc-docs-(x86_64|aarch64)-unknown-linux-gnu (so no extra components are being precompiled), but technically it could still be considered as an unintentional spam.

r? t-bootstrap

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 20, 2026
@rami3l
Copy link
Member Author

rami3l commented Jan 20, 2026 •
edited
Loading

Technically this is a breaking change, since my previous #150289 has made it possible to use rustup to install rustc-docs-x86_64-unknown-linux-gnu in v1.94 which seems to have been feature-frozen, so this fix will expose rustc-docs-<host_target> and remove the former which could be considered as breaking.

However, I'd argue that the impact of this breakage is limited because:

  • Previously, names of certain components have been changed over time, which are briefly logged on a page for which I have write access and can update easily.
  • rustc-docs has been broken for a very long time (can't install rustc-docs component: detected conflict: 'share/doc/rust/html/rustc' #75833 dates back to 2020), to the point where it even hasn't been included in the full profile. Also, it's intended mostly for internal usages due to its highly specific contents. Thus, it is not expected that many would actually download the component even if it reaches stable in v1.94.

Alternatively, we could special-case rustc-docs-(x86_64|aarch64)-unknown-linux-gnu so that this is no longer breaking.

@Urgau
Copy link
Member

Urgau commented Jan 20, 2026

I personally consider the rustc-docs component to be an implementation detail, and as such to not be subject to our usual stability guarantees.

So I wouldn't worry about a potential breaking change.

@rami3l rami3l force-pushed the dist/rustc-docs-target-limit branch from 0973738 to cf3738a Compare January 20, 2026 21:47
jieyouxu
jieyouxu approved these changes Jan 21, 2026
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, thanks

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Jan 21, 2026

@bors r+ rollup=never

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 21, 2026

📌 Commit cf3738a has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 21, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 21, 2026

☀️ Test successful - CI
Approved by: jieyouxu
Duration: 3h 16m 46s
Pushing 625b63f to main...

@rust-bors rust-bors bot merged commit 625b63f into rust-lang:main Jan 21, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 838db25 (parent) -> 625b63f (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 625b63f9e148d511e187c71e5f70643ee62c77fb --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 10212.0s -> 6045.6s (-40.8%)
  2. dist-apple-various: 3961.0s -> 5155.7s (+30.2%)
  3. dist-sparcv9-solaris: 6983.7s -> 5194.7s (-25.6%)
  4. pr-check-1: 2024.6s -> 1666.5s (-17.7%)
  5. x86_64-gnu-llvm-20-1: 4490.6s -> 3768.8s (-16.1%)
  6. aarch64-gnu-llvm-20-1: 3965.7s -> 3415.3s (-13.9%)
  7. x86_64-gnu-llvm-21-3: 7558.8s -> 6523.8s (-13.7%)
  8. x86_64-rust-for-linux: 3094.7s -> 2672.6s (-13.6%)
  9. x86_64-gnu-gcc: 4219.5s -> 3760.6s (-10.9%)
  10. tidy: 149.0s -> 165.0s (+10.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Jan 21, 2026

Finished benchmarking commit (625b63f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -4.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.4% [-4.4%, -4.4%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary 0.6%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) 0.6% [0.6%, 0.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.653s -> 474.946s (0.49%)
Artifact size: 383.22 MiB -> 383.21 MiB (-0.00%)

enthropy7 pushed a commit to enthropy7/rust that referenced this pull request Jan 21, 2026
@bors @enthropy7
Auto merge of rust-lang#151416 - rami3l:dist/rustc-docs-target-limit,…
7603670 
… r=jieyouxu

fix(build-manifest)!: limit `rustc-docs` to current host target in the manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

merged-by-bors This PR was explicitly merged by bors.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rami3l @Urgau @jieyouxu @rust-timer @rustbot