Skip to content

mgca: Type-check fields of struct expr const args #150713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
camelid wants to merge 2 commits into
base: main
Choose a base branch
from
Open

mgca: Type-check fields of struct expr const args #150713

camelid wants to merge 2 commits into from

Conversation

@camelid
Copy link
Member

@camelid camelid commented Jan 5, 2026 •
edited by rustbot
Loading

Fixes #150623.
Fixes #150712. Fixes #150714. Fixes #150734.

r? @BoxyUwU

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

changes to the core type system

cc @lcnr

HIR ty lowering was modified

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 6, 2026

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Jan 6, 2026

☔ The latest upstream changes (presumably #150726) made this pull request unmergeable. Please resolve the merge conflicts.

@Kivooeo
Copy link
Member

Kivooeo commented Jan 6, 2026

Also it fixes this issues with tuple ctor

#150712
#150714
#150734

@BoxyUwU BoxyUwU mentioned this pull request Jan 7, 2026
Open
29 tasks
@camelid camelid force-pushed the mgca-typeck-struct-fields branch from dd0ba66 to d7d2f7e Compare January 8, 2026 00:09
@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Jan 8, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2026

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot

This comment has been minimized.

Sign in to view
@camelid
Copy link
Member Author

camelid commented Jan 8, 2026

Ready once #150675 lands (will need another rebase then too).

@camelid camelid force-pushed the mgca-typeck-struct-fields branch from d7d2f7e to a9749be Compare January 8, 2026 18:53
@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 8, 2026

thx gamer

r=me once CI passes

@camelid camelid added A-const-generics Area: const generics (parameters and arguments) F-min_generic_const_args `#![feature(min_generic_const_args)]` labels Jan 8, 2026
@camelid
Copy link
Member Author

camelid commented Jan 8, 2026

@bors r=BoxyUwU

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 8, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

📌 Commit 1c2cb16 has been approved by BoxyUwU

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 9, 2026
@matthiaskrgr
Rollup merge of rust-lang#150713 - mgca-typeck-struct-fields, r=BoxyUwU
88beaf7 
mgca: Type-check fields of struct expr const args

Fixes rust-lang#150623.
Fixes rust-lang#150712. Fixes rust-lang#150714. Fixes rust-lang#150734.

r? @BoxyUwU
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 9, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 9, 2026
@matthiaskrgr
Rollup merge of rust-lang#150713 - mgca-typeck-struct-fields, r=BoxyUwU
83bea58 
mgca: Type-check fields of struct expr const args

Fixes rust-lang#150623.
Fixes rust-lang#150712. Fixes rust-lang#150714. Fixes rust-lang#150734.

r? @BoxyUwU
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 9, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 9, 2026
@matthiaskrgr
Rollup merge of rust-lang#150713 - mgca-typeck-struct-fields, r=BoxyUwU
3723c18 
mgca: Type-check fields of struct expr const args

Fixes rust-lang#150623.
Fixes rust-lang#150712. Fixes rust-lang#150714. Fixes rust-lang#150734.

r? @BoxyUwU
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BoxyUwU BoxyUwU

Labels

A-const-generics Area: const generics (parameters and arguments) F-min_generic_const_args `#![feature(min_generic_const_args)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

6 participants

@camelid @rustbot @rust-log-analyzer @bors @Kivooeo @BoxyUwU