ptr_aligment_type: add more APIs #148764

GrigorenkoPV · 2025-11-09T20:04:54Z

As per #102070 (comment)

Tracking issue: #102070

Mostly duplicating methods that previously worked with usize-represented alignments.

Naming follows a convention of align: usize, alignment: Alignment.

rustbot · 2025-11-09T20:04:58Z

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

GrigorenkoPV · 2025-11-09T20:52:56Z

Conflicts with #148769, let's wait for that first

joboet · 2025-11-09T21:13:47Z

I really prefer the current spelling of Alignment::of as opposed to alignment_of and therefore would like to suggest adding of_val and of_val_raw as associated methods instead of free-standing functions in mem.

scottmcm · 2025-11-09T23:22:48Z

library/core/src/alloc/layout.rs

    // (However, we do not analogously require `align >= sizeof(void*)`,
    //  even though that is *also* a requirement of `posix_memalign`.)
-    align: Alignment,
+    alignment: Alignment,


This rename is so big that github hides it by default.

Please make this PR just the api addition. If you also want to rename this field, that's fine, but please do it separately because of how much it touches.

scottmcm · 2025-11-09T23:23:22Z

library/core/src/alloc/layout.rs

+    const fn is_size_alignment_valid(size: usize, alignment: Alignment) -> bool {
+        if size > Self::max_size_for_alignment(alignment) {
            return false;
        }
        true
    }


fix: you don't need the return, the true, or the false here.

GrigorenkoPV · 2025-11-10T10:12:45Z

Looks like the failure is due to the rename of master branch and is unrelated to this PR

bors · 2025-11-20T23:31:59Z

☔ The latest upstream changes (presumably #149109) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-12-27T14:03:27Z

☔ The latest upstream changes (presumably #149775) made this pull request unmergeable. Please resolve the merge conflicts.

scottmcm · 2025-12-30T19:30:35Z

Note that this is still a draft so I haven't been looking at it.

After you next rebase, please undraft it and @rustbot ready so it'll show up in my queue again.

scottmcm · 2026-01-18T20:47:02Z

Is this ready to go now? I see it's still a draft -- do you need to click this button?

GrigorenkoPV · 2026-01-18T22:45:11Z

Oh yeah, I was waiting for CI to pass.

@rustbot ready

rustbot · 2026-01-20T14:17:37Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

scottmcm · 2026-01-24T23:31:08Z

@bors r+

rust-bors · 2026-01-24T23:31:11Z

📌 Commit bc0cce1 has been approved by scottmcm

It is now in the queue for this repository.

ptr_aligment_type: add more APIs As per rust-lang#102070 (comment) Tracking issue: rust-lang#102070 Mostly duplicating methods that previously worked with `usize`-represented alignments. Naming follows a convention of `align: usize`, `alignment: Alignment`.

…uwer Rollup of 11 pull requests Successful merges: - #145393 (Add codegen test for removing trailing zeroes from `NonZero`) - #148764 (ptr_aligment_type: add more APIs) - #149869 (std: avoid tearing `dbg!` prints) - #150065 (add CSE optimization tests for iterating over slice) - #150842 (Fix(lib/win/thread): Ensure `Sleep`'s usage passes over the requested duration under Win7) - #151505 (Various refactors to the proc_macro bridge) - #151560 (relnotes: fix 1.93's `as_mut_array` methods) - #151611 (Improve is_ascii performance on x86_64 with explicit SSE2 intrinsics) - #151317 (x86 soft-float feature: mark it as forbidden rather than unstable) - #151577 (Rename `DepKindStruct` to `DepKindVTable`) - #151620 (Fix 'the the' typo in library/core/src/array/iter.rs)

Rollup of 10 pull requests Successful merges: - #145393 (Add codegen test for removing trailing zeroes from `NonZero`) - #148764 (ptr_aligment_type: add more APIs) - #149869 (std: avoid tearing `dbg!` prints) - #150065 (add CSE optimization tests for iterating over slice) - #150842 (Fix(lib/win/thread): Ensure `Sleep`'s usage passes over the requested duration under Win7) - #151505 (Various refactors to the proc_macro bridge) - #151560 (relnotes: fix 1.93's `as_mut_array` methods) - #151317 (x86 soft-float feature: mark it as forbidden rather than unstable) - #151577 (Rename `DepKindStruct` to `DepKindVTable`) - #151620 (Fix 'the the' typo in library/core/src/array/iter.rs)

Rollup merge of #148764 - GrigorenkoPV:aligment_api, r=scottmcm ptr_aligment_type: add more APIs As per #102070 (comment) Tracking issue: #102070 Mostly duplicating methods that previously worked with `usize`-represented alignments. Naming follows a convention of `align: usize`, `alignment: Alignment`.

Rollup of 10 pull requests Successful merges: - rust-lang/rust#145393 (Add codegen test for removing trailing zeroes from `NonZero`) - rust-lang/rust#148764 (ptr_aligment_type: add more APIs) - rust-lang/rust#149869 (std: avoid tearing `dbg!` prints) - rust-lang/rust#150065 (add CSE optimization tests for iterating over slice) - rust-lang/rust#150842 (Fix(lib/win/thread): Ensure `Sleep`'s usage passes over the requested duration under Win7) - rust-lang/rust#151505 (Various refactors to the proc_macro bridge) - rust-lang/rust#151560 (relnotes: fix 1.93's `as_mut_array` methods) - rust-lang/rust#151317 (x86 soft-float feature: mark it as forbidden rather than unstable) - rust-lang/rust#151577 (Rename `DepKindStruct` to `DepKindVTable`) - rust-lang/rust#151620 (Fix 'the the' typo in library/core/src/array/iter.rs)

rustbot assigned scottmcm Nov 9, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 9, 2025

GrigorenkoPV mentioned this pull request Nov 9, 2025

Tracking issue for alloc_layout_extra #55724

Closed