Skip to content

Set the minimum deployment target for aarch64-apple-watchos #147447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

Set the minimum deployment target for aarch64-apple-watchos #147447

merged 1 commit into from
Oct 9, 2025

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Oct 7, 2025 •
edited
Loading

To match what's done in LLVM 21 and Xcode 26, watchOS 26 is the first OS version that actually runs true Aarch64 binaries. This affects the object files we create, and the linker invocation when using -Clinker=ld.

See also investigation in #147223.

@madsmtm madsmtm added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. O-watchos Operating System: watchOS A-targets Area: Concerning the implications of different compiler targets O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) labels Oct 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@madsmtm madsmtm changed the title Set the default deployment target for aarch64-apple-watchos Set the minimum deployment target for aarch64-apple-watchos Oct 7, 2025
@madsmtm madsmtm force-pushed the aarch64-watchos-default-deployment-target branch from b92b86d to a914f82 Compare October 7, 2025 15:21
@madsmtm madsmtm mentioned this pull request Oct 7, 2025
Closed
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 9, 2025

📌 Commit a914f82 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 9, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#147447 - madsmtm:aarch64-watchos-default-de…
8545b39 
…ployment-target, r=davidtwco

Set the minimum deployment target for `aarch64-apple-watchos`

To match what's done in LLVM 21 and Xcode 26, watchOS 26 is the first OS version that actually runs true Aarch64 binaries. This affects the object files we create, and the linker invocation when using `-Clinker=ld`.

See also investigation in rust-lang#147223.
bors added a commit that referenced this pull request Oct 9, 2025
@bors
Auto merge of #147531 - matthiaskrgr:rollup-2lmnn4s, r=matthiaskrgr
81f15b7 
Rollup of 4 pull requests

Successful merges:

 - #147447 (Set the minimum deployment target for `aarch64-apple-watchos`)
 - #147479 (cmse: improve error messages)
 - #147515 (Update rustc-perf submodule)
 - #147523 (x86_64-bigint-helpers test: update test assertion to cover registers r8 and r9)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Oct 9, 2025

⌛ Testing commit a914f82 with merge b925a86...

@bors
Copy link
Collaborator

bors commented Oct 9, 2025

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing b925a86 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 9, 2025
@bors bors merged commit b925a86 into rust-lang:master Oct 9, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0b278a5 (parent) -> b925a86 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b925a865e2c9a0aefe5a2877863cb4df796f2eaf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 8687.0s -> 6673.7s (-23.2%)
  2. dist-aarch64-apple: 6861.1s -> 8371.7s (22.0%)
  3. aarch64-apple: 8822.8s -> 10276.7s (16.5%)
  4. x86_64-gnu-debug: 6386.8s -> 7002.3s (9.6%)
  5. tidy: 183.9s -> 200.9s (9.2%)
  6. aarch64-msvc-2: 5024.2s -> 5484.3s (9.2%)
  7. dist-aarch64-windows-gnullvm: 4658.1s -> 5080.3s (9.1%)
  8. dist-x86_64-musl: 8567.1s -> 7802.4s (-8.9%)
  9. pr-check-1: 1533.3s -> 1403.0s (-8.5%)
  10. dist-armv7-linux: 5197.1s -> 4807.6s (-7.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@madsmtm madsmtm deleted the aarch64-watchos-default-deployment-target branch October 9, 2025 21:26
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b925a86): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.6% [0.5%, 0.6%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.5% [-0.5%, -0.5%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.3% [-1.3%, -1.3%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.0% [3.0%, 3.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.6% [-4.6%, -4.6%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.191s -> 472.277s (-0.19%)
Artifact size: 388.07 MiB -> 388.06 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-targets Area: Concerning the implications of different compiler targets merged-by-bors This PR was explicitly merged by bors. O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) O-watchos Operating System: watchOS S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@madsmtm @rustbot @davidtwco @bors @rust-timer