Skip to content

PassWrapper: use non-deprecated lookupTarget method #147446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

PassWrapper: use non-deprecated lookupTarget method #147446

merged 1 commit into from
Oct 9, 2025
+4 −0

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented Oct 7, 2025

This avoids an extra trip through a triple string by directly passing the Triple, and has been available since LLVM 21. The string overload was deprecated today and throws an error on our CI for HEAD due to -Werror paranoia, so we may as well clean this up now and also skip the conversion on LLVM 21 since we can.

@rustbot label llvm-main

@durin42
PassWrapper: use non-deprecated lookupTarget method
eb20c6a 
This avoids an extra trip through a triple string by directly passing
the Triple, and has been available since LLVM 21. The string overload
was deprecated today and throws an error on our CI for HEAD due to
-Werror paranoia, so we may as well clean this up now and also skip the
conversion on LLVM 21 since we can.

@rustbot label llvm-main
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Oct 7, 2025
@Zalathar
Copy link
Contributor

Zalathar commented Oct 9, 2025

LGTM, thanks.

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 9, 2025

📌 Commit eb20c6a has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2025
@Zalathar Zalathar mentioned this pull request Oct 9, 2025
Merged
bors added a commit that referenced this pull request Oct 9, 2025
@bors
Auto merge of #147519 - Zalathar:rollup-o5f16uo, r=Zalathar
4b57d81 
Rollup of 3 pull requests

Successful merges:

 - #147446 (PassWrapper: use non-deprecated lookupTarget method)
 - #147473 (Do `x check` on various bootstrap tools in CI)
 - #147509 (remove intrinsic wrapper functions from LLVM bindings)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c33f0b3 into rust-lang:master Oct 9, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 9, 2025
rust-timer added a commit that referenced this pull request Oct 9, 2025
@rust-timer
Unrolled build for #147446
c7563ce 
Rollup merge of #147446 - durin42:llvm-22-lookupTarget-deprecation, r=Zalathar

PassWrapper: use non-deprecated lookupTarget method

This avoids an extra trip through a triple string by directly passing the Triple, and has been available since LLVM 21. The string overload was deprecated today and throws an error on our CI for HEAD due to -Werror paranoia, so we may as well clean this up now and also skip the conversion on LLVM 21 since we can.

`@rustbot` label llvm-main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuviper cuviper

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@durin42 @rustbot @Zalathar @bors @cuviper