Implement Display, LowerExp, and UpperExp, and FromStr for f128.#146406
Draft
bjoernager wants to merge 1 commit intorust-lang:mainfrom
Draft
Implement Display, LowerExp, and UpperExp, and FromStr for f128.#146406bjoernager wants to merge 1 commit intorust-lang:mainfrom
Display, LowerExp, and UpperExp, and FromStr for f128.#146406bjoernager wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
Contributor
Author
|
@rustbot label +F-f16_and_f128 +T-libs-api -T-libs r? libs-api |
e5f3a2e to
1b7caab
Compare
This comment has been minimized.
This comment has been minimized.
Display, LowerExp, and UpperExp for f128.Display, LowerExp, UpperExp, and FromStr for f128.
Display, LowerExp, UpperExp, and FromStr for f128.Display, LowerExp, and UpperExp for f128.
1b7caab to
fa82afa
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Display, LowerExp, and UpperExp for f128.Display, LowerExp, and UpperExp, and FromStr for f128.
Contributor
|
☔ The latest upstream changes (presumably #151716) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Please disregard this PR for the moment as it will require a bit more attention).
Tracking issue: #116909.
Of the formatting traits,
f128currently only implementsDebug.f16, meanwhile, additionally implementsDisplay,LowerExp, andUpperExp, with a conditional fallback toDebugon some targets.This PR ports these implementations to
f128as well, with equivalent fallbacks for targets without proper support.This PR also implements
FromStrforf128. On the targets that natively support such numbers, this implementation will work as expected. On other targets, a run-time panic will encur for now (this is similarly done forf16already).